Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMR concept inventory #58

Open
goodmami opened this issue Jan 29, 2020 · 8 comments
Open

Add AMR concept inventory #58

goodmami opened this issue Jan 29, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@goodmami
Copy link
Owner

This depends on #57, although #57 will be informed by this issue.

The AMR concept inventory is, as I understand, a fork of Propbank frames. It is packaged with the LDC release which I don't have access to and also raises questions of licensing if I were to include (a derived form of) those in this repository.

There's a plain-text version, that I think is equivalent, at https://amr.isi.edu/doc/propbank-amr-frames-arg-descr.txt

One thing I could do here is make a reader or converter for the frame files so someone with access to the LDC release could create the appropriate files for Penman to use. I just need to confirm the format of those files, then.

@goodmami goodmami added the enhancement New feature or request label Jan 29, 2020
@goodmami goodmami added the good first issue Good for newcomers label Oct 20, 2020
@goodmami
Copy link
Owner Author

@flipz357 I see that you have included the above-linked file in Smatch++ here:

https://github.com/flipz357/smatchpp/blob/main/smatchpp/resource/propbank-amr-frames-arg-descr.txt

The main reason I haven't included it here is because I don't see any licensing information along the file. Do you know what are the terms for redistribution, or who I would ask about that?

@flipz357
Copy link

flipz357 commented Oct 29, 2023

Yeah... Smatch++ uses it for some ---optional, experimental--- "semantic" AMR standardization and fine-grained scoring. The idea is that, e.g., to cut out "causal" sub-graphs from AMR, we do not only want to retrieve :cause/cause-01 graph parts, but also any arg_x that may be labeled as a "cause" in propbank. Similar for other aspects like location, time, etc.

Maybe I wrongly presumed it is under free public license (what license are even the AMR guidelines, it doesn't say anything?). I also do not know who can know more about this. I'll think about it.

@goodmami
Copy link
Owner Author

@timjogorman, since your name is on both the AMR 3.0 LDC release and on the Propbank organization, I'm hoping you might be able to help us with the above question, paraphrased here for convenience:

  • Does the plaintext Propbank AMR frames list here have any license or terms of redistribution associated with it?

I suspect it is just an export of https://github.com/propbank/propbank-frames, in which case it may fall under the latter's CC-BY-SA-4.0 license? Also, it's not in the resource lists of AMR's Download page, which gives the impression that it's an internal file not meant for redistribution.

@flipz357
Copy link

flipz357 commented Oct 31, 2023 via email

@goodmami
Copy link
Owner Author

goodmami commented Nov 1, 2023

it's explicitly linked from the AMR guidelines

Ah, nice, that's reassuring. I thought I'd found it through a more obscure link in the AMR Dictionary or similar.

@timjogorman
Copy link

For licensing: I don't have an official answer for this but I'd assume it falls under the CC-BY-SA-4.0 license .

More generally: For the latest version of Propbank frame versions they have added a "usage" field in the frame files, marking which projects each frame was available for. So one should be able to pull the information that's in that plain-text file from the latest frames , filtering for their usage in the AMR release. I apologize that we never got out an API for Propbank that would make things like that easier; doing so should be much easier than it is.

@goodmami
Copy link
Owner Author

goodmami commented Nov 4, 2023

@timjogorman thanks for answering, even if unofficially :)
It sounds like the safer thing to do in terms of licensing is point to the Propbank Frames source and write some code to extract the relevant info. Thanks for pointing out the "usage" field, which should help in determining what is available to AMR.

@flipz357
Copy link

Within Smatch++ I implemented a first version of the solution of loading frame files on demand. If you want, you can use/adapt the two functions that I have now implemented:

checking availability, and maybe downloading and returning a python dict with frames

downloading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants