Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usar un skeleton en vez de un spinner como fallback para pages/[slug]/index #172

Open
goncy opened this issue Jul 30, 2020 · 1 comment
Open
Assignees
Labels
good first issue Good for newcomers

Comments

@goncy
Copy link
Owner

goncy commented Jul 30, 2020

Haciendo uso del componente skeleton de chakra https://chakra-ui.com/skeleton reemplazar el spinner que se usa como fallback con un layout aproximado hecho con skeletons.

Una vez hecho eso, podria moverse el archivo de app/screens/Loading a session/secreens/Loading

A tener en cuenta: Que el skeleton funcione bien en mobile y desktop, se puede usar como referencia products/screens/Products y usar el componente ui/structure/Container

Nice to have: Crear un layout en app/layouts/StoreSkeletonLayout basado en app/layouts/StoreLayout con la data por defecto mientras la tienda esta cargando

SUPER RECONTRA NICE TO HAVE: Analizar el user agent y si es un bot (de google o cualquier otro) retornar el header Retry after https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After en 10 segundos para esperar que termine de buildear

@goncy goncy added the good first issue Good for newcomers label Jul 30, 2020
@matiasperz
Copy link
Contributor

Lo tomo 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants