Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev and build commands not working #9

Open
ashNotKetchup opened this issue Jul 20, 2022 · 4 comments
Open

Dev and build commands not working #9

ashNotKetchup opened this issue Jul 20, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ashNotKetchup
Copy link
Collaborator

ashNotKetchup commented Jul 20, 2022

At the moment, nothing will build, argh! Will add error logs as and when I come across them.

Replicate:

  • Fetch the latest update from repo (I'm also intrigued to see if this happens with old copies too)
  • Open terminal in that folder
  • Try either Dev(yarn then yarn local dev) or Build (yarn then yarn local build)

Questions:

  • Does this happen with windows machines?
  • What errors (if any) is everyone else getting?

Extra marks:

  • Does this happen when downloading the source code from the releases, then running them as above?

EDIT:

If getting the "mermaid.js" error, do the following:

  • Remove all mention of mermaid js from devdependencies in the root directory's package.json
  • Remove all mention of mermaid js from devdependencies in the shared directory's package.json
  • Remove all text from yarn.lock

Then, restart the instructions from the original post above

@ashNotKetchup ashNotKetchup added the bug Something isn't working label Jul 20, 2022
@demzou
Copy link
Collaborator

demzou commented Aug 2, 2022

Test building on windows machine. Build successful but error once launching the app:

Uncaught Error: Electron failed to install correctly, please delete node_modules/electron and try installing again
    at ry (index.js:17:11)
    at index.js:21:18

@ashNotKetchup
Copy link
Collaborator Author

Looking into this a little more, seems like it could be an issue with using import rather than require? Or with requiring something we shouldn't be?

For example:

electron/electron#7300 (comment)

@ashNotKetchup
Copy link
Collaborator Author

Seems like there has been an issue with broken dependencies relating to electron (specifically ipcRenderer) following an update. We're not sure which so we have temporarily solved this by committing Oli's yarn.lock file to the repo. This has the effect of locking all dependencies to specific versions specified in that lock file, guaranteeing that anyone who pulls this file will get those versions (which work).

Something has changed in electron/its typescript definitions, we need to upgrade the dependencies to the latest version and figure out what has gone wrong.

@ashNotKetchup
Copy link
Collaborator Author

Possible methods for figuring out broken dependencies:

  • Yarn.lock file comparison
  • Upgrade single dependencies one at a time using yarn upgrade-interactive

ashNotKetchup added a commit that referenced this issue Aug 3, 2022
We found a temporary fix for some of the dependency stuff, see [issue 9](#9 (comment))

Co-Authored-By: Oliver Winks <oliver@paperplane.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants