Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool version check occurs too late #3316

Open
hyangah opened this issue Apr 4, 2024 · 1 comment
Open

Tool version check occurs too late #3316

hyangah opened this issue Apr 4, 2024 · 1 comment
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 4, 2024

The extension offers to update tools if the tools are too old.
Unfortunately, it occurs too late - after gopls starts. This doesn't play nicely with gopls's crashes.

await commands.startLanguageServer(ctx, goCtx)(RestartReason.ACTIVATION);
suggestUpdates();
offerToInstallLatestGoVersion(ctx);

Moreover, #3168 also kicks in, and prevents from compiling tools with the suitable go versions.

@hyangah hyangah added this to the v0.41.3 milestone Apr 4, 2024
@gopherbot gopherbot modified the milestones: v0.41.3, Untriaged Apr 4, 2024
@hyangah hyangah modified the milestones: Untriaged, v0.41.3 Apr 4, 2024
@hyangah
Copy link
Contributor Author

hyangah commented Apr 6, 2024

Hope that fixing #3168 helps this. We also have a new gopls release with the known crash causes fixed.
Since it requires non-trivial refactoring work, moving this to v0.42.0

@hyangah hyangah modified the milestones: v0.41.3, v0.42.0 Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants