Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add macOS security trybots to LUCI #67073

Open
dmitshur opened this issue Apr 26, 2024 · 5 comments
Open

x/build: add macOS security trybots to LUCI #67073

dmitshur opened this issue Apr 26, 2024 · 5 comments
Assignees
@prattmic @dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Darwin
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

We have macOS builders in LUCI, but they're not yet available as security trybots. This is the tracking issue for that.
@dmitshur dmitshur added OS-Darwin Builders x/build issues (builders, bots, dashboards) new-builder labels Apr 26, 2024
@dmitshur dmitshur added this to the Unreleased milestone Apr 26, 2024
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 26, 2024
@gopherbot
Copy link

Change https://go.dev/cl/582095 mentions this issue: main.star: add security-only known issues

@gopherbot
Copy link

Change https://go.dev/cl/582096 mentions this issue: main.star: add darwin-amd64_14 builder to the internal host

@gopherbot
Copy link

Change https://go.dev/cl/582036 mentions this issue: cmd/makemac: add first security macOS trybot

gopherbot pushed a commit to golang/build that referenced this issue Apr 30, 2024
@dmitshur @gopherbot
main.star: add security-only known issues
12b2e3e 
The next CL adds the darwin-amd64_14 builder type to the security trybot
environment. I'd like it to have a known issue set to begin with, so add
a SECURITY_KNOWN_ISSUE_BUILDER_TYPES dictionary and propagate it to make
that possible.

Some code rearrangement unfortunately happens to avoid "global variable
referenced before assignment" errors. :(

For golang/go#67073.

Change-Id: I31d4354d0deadb944bae30cd0f07a85bb9c4e2e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/582095
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Apr 30, 2024
@dmitshur @gopherbot
main.star: add darwin-amd64_14 builder to the internal host
a1b760d 
A new distinct set of VMs will be used for security pre-submit
and release testing. Start with one builder with a known issue.

For golang/go#67073.

Change-Id: I86b1ed2ae238ca87666e00938b6b50af722f5b96
Reviewed-on: https://go-review.googlesource.com/c/build/+/582096
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/582558 mentions this issue: main.star: permit makemac to list security bots

gopherbot pushed a commit to golang/build that referenced this issue May 1, 2024
@dmitshur @gopherbot
main.star: permit makemac to list security bots
4d6c7ca 
It needs read-only access to list bots in chrome-swarming, so it
can know whether to launch or renew or destroy MacService leases.

For golang/go#67073.

Change-Id: Ida562721f4931b2309508e01b320605343fe90e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/582558
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue May 3, 2024
@dmitshur @gopherbot
cmd/makemac: add first security macOS trybot
a705825 
For golang/go#67073.

Change-Id: Ic80c778a624b1f68b3407ba16fcbd2d1ce61c0dd
Reviewed-on: https://go-review.googlesource.com/c/build/+/582036
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/583116 mentions this issue: main.star: remove known issue for darwin-amd64_14 security builder

gopherbot pushed a commit to golang/build that referenced this issue May 6, 2024
@dmitshur @gopherbot
main.star: remove known issue for darwin-amd64_14 security builder
be32b0e 
By now everything should be set up for it to work okay.

For golang/go#67073.

Change-Id: Ib0f2559b5e03706fe424fe3e6f2033a6ed3fa62f
Reviewed-on: https://go-review.googlesource.com/c/build/+/583116
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Darwin
Projects
Go Release
Status: In Progress
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot