New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: T.FailNow used in goroutines in standard library tests #17900
Labels
Comments
@dominikh did you use a tool to find these? |
@cespare The output is from a work in progress check for staticcheck (dominikh/go-staticcheck@7f04f97) |
CL https://golang.org/cl/33243 mentions this issue. |
FiloSottile
pushed a commit
to FiloSottile/go
that referenced
this issue
Oct 12, 2018
Fixes golang#17900. Change-Id: I42cda6ac9cf48ed739d3a015a90b3cb15edf8ddf Reviewed-on: https://go-review.googlesource.com/33243 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
FiloSottile
pushed a commit
to FiloSottile/go
that referenced
this issue
Oct 12, 2018
Fixes golang#17900. Change-Id: I42cda6ac9cf48ed739d3a015a90b3cb15edf8ddf Reviewed-on: https://go-review.googlesource.com/33243 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Per the documentation on testing.T, the methods FailNow, Fatal, Fatalf, SkipNow, Skip, and Skipf must be called from the same goroutine that is running the test. This requirement is violated by various tests in the standard library.
The following is a list of all goroutines spawned in tests that call T.FailNow. The list was generated from revision 2f49726.
The text was updated successfully, but these errors were encountered: