{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23096959,"defaultBranch":"master","name":"go","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-19T04:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1712158552.0","currentOid":""},"activityList":{"items":[{"before":"ceef0633b3c5bbf5d17a12d6e663c136b30b3f36","after":"774d5b366ce43ed7e304ea3917e353112df9daf7","ref":"refs/heads/master","pushedAt":"2024-04-27T11:30:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"make.bash: avoid ksh bug in nogoenv\n\nksh handles make.bash surprisingly well and is a smaller\nsupply chain attack surface, so it's reasonable to want\nto use \"ksh make.bash\" to build Go.\n\nThe only place where ksh and bash disagree in running\nmake.bash is an arguable bug in ksh that\n\n\tX=Y foo\n\naccidentally changes the real value of X following that\ncommand when foo is a shell function. (It correctly preserves\nthe original value of X when foo is a command being invoked.)\n\nMore specifically,\n\n\tGOROOT=$GOROOT_BOOTSTRAP nogoenv foo\n\nincorrectly changes $GOROOT in the rest of the script.\n\nCL 580020 suggested using a subshell, but subshells\nhistorically have lost \"set -e\", so we'd have to use (...) || exit 1.\nInstead of that, this CL refactors nogoenv into bootstrapenv,\nputting it in charge of changing $GOROOT the same way it\nchanges all the other environment variables.\n\nThis CL also updates make.rc for parallelism.\nIt does not bother updating make.bat: that part is already\na bit different, and attempting to change it is all risk, no reward.\n\nChange-Id: I5923a6fb5016a3862363363859365d1cd4f61a1d\nReviewed-on: https://go-review.googlesource.com/c/go/+/582076\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Eric Grosse ","shortMessageHtmlLink":"make.bash: avoid ksh bug in nogoenv"}},{"before":"ad22356ec660844ec43ccbe9a834845f1a6f7cf8","after":"ceef0633b3c5bbf5d17a12d6e663c136b30b3f36","ref":"refs/heads/master","pushedAt":"2024-04-26T23:08:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"path/filepath, internal/filepathlite: move parts of filepath to filepathlite\n\nThe path/filepath package needs to depend on the os package to\nimplement Abs, Walk, and other functions. Move the implementation\nof purely lexical functions from path/filepath into\ninternal/filepathlite, so they can be used by os and\nother low-level packages.\n\nChange-Id: Id211e547d6f1f58c82419695ff2d75cd6cd14a12\nReviewed-on: https://go-review.googlesource.com/c/go/+/566556\nReviewed-by: Behroz Karimpor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"path/filepath, internal/filepathlite: move parts of filepath to filep…"}},{"before":"1c4704991aeae5c9e0c6816a227390829b724ab5","after":"ad22356ec660844ec43ccbe9a834845f1a6f7cf8","ref":"refs/heads/master","pushedAt":"2024-04-26T23:07:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: rename internal/safefilepath to internal/filepathlite\n\nThe safefilepath package was originally added to contain\nthe FromFS function. We subsequently added FromFS to path/filepath\nas Localize. The safefilepath package now exists only to permit\nthe os package to import Localize.\n\nRename safefilepath to filepathlite to better indicate that it's\na low-dependency version of filepath.\n\nChange-Id: I4c5f9b28e8581f841947b48c5cac9954cd0c9535\nReviewed-on: https://go-review.googlesource.com/c/go/+/581517\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"all: rename internal/safefilepath to internal/filepathlite"}},{"before":"9effeeab27de2a8f75a1050ce879ba8db3abb406","after":"1c4704991aeae5c9e0c6816a227390829b724ab5","ref":"refs/heads/master","pushedAt":"2024-04-26T22:56:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"testing: use QueryPerformanceCounter on Windows\n\nWindows time.Now granularity is around 0.5ms on modern systems,\nwhich introduces a significant noise into benchmark results.\nInstead of relying time.Now use QueryPerformanceCounter, which\nhas significantly better granularity compared to time.Now.\n\n │ TimeNow-32 │ HighPrecisionTimeNow-32 │\n │ sec/op │ sec/op vs base │\n 4.812n ± 0% 30.580n ± 0% +535.43% (p=0.000 n=20)\n\nFixes #31160\n\nChange-Id: Ib2a574d638c9c6762a2524212def02265574e267\nReviewed-on: https://go-review.googlesource.com/c/go/+/557315\nReviewed-by: Quim Muntal \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alex Brainman \nReviewed-by: Cherry Mui \nReviewed-by: Michael Knyszek ","shortMessageHtmlLink":"testing: use QueryPerformanceCounter on Windows"}},{"before":"b439f3285962e9a263ea7511f19aac0a875d17cf","after":"9effeeab27de2a8f75a1050ce879ba8db3abb406","ref":"refs/heads/master","pushedAt":"2024-04-26T22:13:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/weak: remove unnecessary conversion, fix typo\n\nRemove unnecessary conversion from unsafe.Pointer to unsafe.Pointer.\nAlso fix small typo in weak.Pointer.Strong method documentation.\n\nChange-Id: I84791fba244581bd6218c589827a61914f0797b4\nGitHub-Last-Rev: 7978d07d5bbd72ca84c9650bf2450d7a269bbb1d\nGitHub-Pull-Request: golang/go#66977\nReviewed-on: https://go-review.googlesource.com/c/go/+/580936\nReviewed-by: Michael Knyszek \nCommit-Queue: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Joedian Reid \nAuto-Submit: Ian Lance Taylor ","shortMessageHtmlLink":"internal/weak: remove unnecessary conversion, fix typo"}},{"before":"0e7f5cf30ba43f4d388803642b4173e5af20e761","after":"b439f3285962e9a263ea7511f19aac0a875d17cf","ref":"refs/heads/master","pushedAt":"2024-04-26T21:33:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: make use of sync.Map.Clear\n\nSince CL 515015 added sync.Map.Clear method, we can use it to make\nthe code simpler and clearer.\n\nChange-Id: I29edc969431b4fd95cd5fd864953a71ca1538dd3\nReviewed-on: https://go-review.googlesource.com/c/go/+/582015\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Joedian Reid \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"all: make use of sync.Map.Clear"}},{"before":"b384ee7cebe1b386e324dcca2c93beb96ea31c9e","after":"0e7f5cf30ba43f4d388803642b4173e5af20e761","ref":"refs/heads/master","pushedAt":"2024-04-26T21:25:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/README.md: discourage RELNOTE in CLs\n\nRelease notes should always be files under doc/next. Make it clear that\nthis is the only way to add them: RELNOTE markers in CLs are no longer\nsupported.\n\nChange-Id: I34d77eb876f57b84ecdc7e5ecbf3eb5c91e6fed8\nReviewed-on: https://go-review.googlesource.com/c/go/+/582075\nReviewed-by: Dmitri Shuralyov \nTryBot-Bypass: Jonathan Amsterdam \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"doc/README.md: discourage RELNOTE in CLs"}},{"before":"196916299da7568a2a2165246e5164637df03fb9","after":"b384ee7cebe1b386e324dcca2c93beb96ea31c9e","ref":"refs/heads/master","pushedAt":"2024-04-26T18:13:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net, os, internal/poll: test for use of sendfile\n\nThe net package's sendfile tests exercise various paths where\nwe expect sendfile to be used, but don't verify that sendfile\nwas in fact used.\n\nAdd a hook to internal/poll.SendFile to let us verify that\nsendfile was called when expected. Update os package tests\n(which use their own hook mechanism) to use this hook as well.\n\nFor #66988\n\nChange-Id: I7afb130dcfe0063d60c6ea0f8560cf8665ad5a81\nReviewed-on: https://go-review.googlesource.com/c/go/+/581778\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"net, os, internal/poll: test for use of sendfile"}},{"before":"deeebf5655eeb91e93e60dbda5c3df294b4d5130","after":"196916299da7568a2a2165246e5164637df03fb9","ref":"refs/heads/master","pushedAt":"2024-04-26T17:09:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net: fix sendfile regression with io.Copy on macOS\n\nSince CL 472475, io.Copy can no longer use sendfile on macOS for copying\nfiles to a socket due to a too strict type assertion. This CL fixes the\nissue by checking for the necessary interfaces instead of the concrete\nos.File type in sendfile_unix_alt.go.\n\nFixes #66988\n\nChange-Id: Ia0dd190f6575016a191c34a935132907147c8e10\nReviewed-on: https://go-review.googlesource.com/c/go/+/581035\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Damien Neil ","shortMessageHtmlLink":"net: fix sendfile regression with io.Copy on macOS"}},{"before":"d6c972ad41043f38bfa31f3c7036e6d8a3361f2d","after":"3f4af1ff0e0c3a83bc48faee3d1f0282ef4d02f2","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-04-26T16:30:23.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] runtime: use bootstrapRand to initialize hashkey\n\nThe seed for rand is not initialized until after alginit. Before\ninitialization, rand returns a deterministic sequence, making hashkey\ndeterministic across processes.\n\nSwitch to bootstrapRand, like other early rand calls, such as\ninitialization of aeskeysched.\n\nFor #66885.\nFixes #66886.\n\nChange-Id: I5023a9161232b49fda2ebd1d5f9338bbdd17b1fe\nReviewed-on: https://go-review.googlesource.com/c/go/+/580136\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \n(cherry picked from commit 1a3682b4c1e44f334c5cc8fbad3c28b853c2aff2)\nReviewed-on: https://go-review.googlesource.com/c/go/+/580018","shortMessageHtmlLink":"[release-branch.go1.22] runtime: use bootstrapRand to initialize hashkey"}},{"before":"2dd82d97b67a538700e30d808122a521e3207c3e","after":"deeebf5655eeb91e93e60dbda5c3df294b4d5130","ref":"refs/heads/master","pushedAt":"2024-04-26T15:39:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link/internal/ld: more fixes to TestElfBindNow readonly .got check\n\nSecond try at fixing the TestElfBindNow testpoint: don't try to check\nfor readonly \".got\" section when using the external linker, since\nthere is code in some linkers (BFD in particular) that will skip\nplacing \".got\" in relro if the section is below a specific size\nthreshold. Revised version of the test checks only for readonly\n\".dynamic\" in the external linking case.\n\nFixes #67063.\n\nChange-Id: Idb6b82ec7893baddf171654775587f6050fc6258\nReviewed-on: https://go-review.googlesource.com/c/go/+/581995\nReviewed-by: Cherry Mui \nReviewed-by: abner chenc \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link/internal/ld: more fixes to TestElfBindNow readonly .got check"}},{"before":"5ff0b531748fcdc88d6667e55e021fe02e0c0089","after":"2dd82d97b67a538700e30d808122a521e3207c3e","ref":"refs/heads/master","pushedAt":"2024-04-26T13:32:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"compress: reordering fields to reduce struct sizes\n\nOverall, there are 32 bytes reduced.\n\nChange-Id: I455bf0874b33fa47719f42618e4800c7ff2a9e88\nGitHub-Last-Rev: 7670344c4a643afdec0fdae3d34fdb8ccd81205f\nGitHub-Pull-Request: golang/go#67010\nReviewed-on: https://go-review.googlesource.com/c/go/+/581355\nReviewed-by: Joedian Reid \nReviewed-by: Keith Randall \nAuto-Submit: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"compress: reordering fields to reduce struct sizes"}},{"before":"5419f652b6593a0916f7b2155435b945e8ee0fb4","after":"5ff0b531748fcdc88d6667e55e021fe02e0c0089","ref":"refs/heads/master","pushedAt":"2024-04-26T13:32:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"bytes: skip TestNewBufferShallow if optimization is disabled\n\nTestNewBufferShallow should be skipped if optimization is disabled.\n\nIt is currently failing on no-opt builders.\n\nChange-Id: Ib5e62022a56a4e5f158f247d69a6229d2cb4d99e\nReviewed-on: https://go-review.googlesource.com/c/go/+/581915\nAuto-Submit: Than McIntosh \nReviewed-by: Than McIntosh \nAuto-Submit: Quim Muntal \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Joedian Reid ","shortMessageHtmlLink":"bytes: skip TestNewBufferShallow if optimization is disabled"}},{"before":"1ca31eac40c0400efc8211bc2483fd621264be11","after":"5419f652b6593a0916f7b2155435b945e8ee0fb4","ref":"refs/heads/master","pushedAt":"2024-04-26T00:40:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"spec: clarify prose for range over numeric range expressions\n\nFixes #66967.\n\nChange-Id: I7b9d62dcb83bad60b2ce74e2e2bf1a36c6a8ae38\nReviewed-on: https://go-review.googlesource.com/c/go/+/581256\nReviewed-by: Robert Griesemer \nReviewed-by: Ian Lance Taylor \nTryBot-Bypass: Robert Griesemer ","shortMessageHtmlLink":"spec: clarify prose for range over numeric range expressions"}},{"before":"57026007c828ac06fe4f8656c1aa497dd3ba40c3","after":"1ca31eac40c0400efc8211bc2483fd621264be11","ref":"refs/heads/master","pushedAt":"2024-04-25T20:24:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link/internal/ld: revised bindnow/relro test for ELF\n\nThis patch re-enables the portion of the TestElfBindNow test that\nverifies that selected sections are in a read-only segment. Turns out\nwe can't always check for read-only \".got\" on all architectures (on\nppc64le for example \".got\" will only turn up if there is CGO use), so\nalways look for readonly \".dynamic\", but only look for readonly \".got\"\nif the section is present.\n\nUpdates #45681.\n\nChange-Id: I4687ae3cf9a81818268925e17700170ba34204a7\nReviewed-on: https://go-review.googlesource.com/c/go/+/581115\nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link/internal/ld: revised bindnow/relro test for ELF"}},{"before":"a8ba163695f605c72156c90de97a06b3e40566ff","after":"57026007c828ac06fe4f8656c1aa497dd3ba40c3","ref":"refs/heads/master","pushedAt":"2024-04-25T20:08:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: teach dse about equivalent LocalAddrs\n\nThis patch teaches DSE that two LocalAddrs of the same variable\nare equal, even if they are from different memory states. This avoids\ndependance on a store into the same LocalAddr being added to\nloadUse even though the store is unnecessary and is in fact\nshadowed.\n\nFixes #59021\n\nChange-Id: I0ef128b783c4ad6fd2236fa5ff20345b4d31eddb\nGitHub-Last-Rev: b80a6b28fb7c86c66ea65282702b3aa032d6f5a5\nGitHub-Pull-Request: golang/go#66793\nReviewed-on: https://go-review.googlesource.com/c/go/+/578376\nReviewed-by: Keith Randall \nAuto-Submit: Keith Randall \nReviewed-by: Joedian Reid \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"cmd/compile: teach dse about equivalent LocalAddrs"}},{"before":"fd99157f9d9c22eb35ea9c70f32908f0980d47ed","after":"a8ba163695f605c72156c90de97a06b3e40566ff","ref":"refs/heads/master","pushedAt":"2024-04-25T18:50:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"runtime: fix mcall unwinding on Windows\n\nThe Windows native stack unwinder incorrectly classifies the next\ninstruction after the mcall callback call as being part of the function\nepilogue, producing a wrong call stack.\n\nAdd a NOP after the callback call to work around this issue.\n\nFixes #67007.\n\nChange-Id: I6017635da895b272b1852391db9a255ca69e335d\nReviewed-on: https://go-review.googlesource.com/c/go/+/581335\nTryBot-Result: Gopher Robot \nReviewed-by: Michael Knyszek \nReviewed-by: Cherry Mui \nRun-TryBot: Quim Muntal \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"runtime: fix mcall unwinding on Windows"}},{"before":"a4031ea1f5e0c40717c6f9d608e51ff3cef1a6eb","after":"fd99157f9d9c22eb35ea9c70f32908f0980d47ed","ref":"refs/heads/master","pushedAt":"2024-04-25T17:50:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types, types2: refactor Checker.rangeStmt for clarity\n\nChange-Id: I0c2f921389416ab222b84f77699fd4b3246ef0e0\nReviewed-on: https://go-review.googlesource.com/c/go/+/581776\nAuto-Submit: Robert Griesemer \nReviewed-by: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"go/types, types2: refactor Checker.rangeStmt for clarity"}},{"before":"06478e4b4659966e4f5dba1f399da9767995fee5","after":"a4031ea1f5e0c40717c6f9d608e51ff3cef1a6eb","ref":"refs/heads/master","pushedAt":"2024-04-25T17:43:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix typos in comments\n\nChange-Id: Ib2e77cff4c10f66316295cbd67f52606cbf9972b\nGitHub-Last-Rev: 088c033b2d5b743ca7739300ad3e9fdf69846669\nGitHub-Pull-Request: golang/go#67032\nReviewed-on: https://go-review.googlesource.com/c/go/+/581675\nAuto-Submit: Keith Randall \nCommit-Queue: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"all: fix typos in comments"}},{"before":"8c0da423f77fff5e206ad777cfc496e935cb3af6","after":"06478e4b4659966e4f5dba1f399da9767995fee5","ref":"refs/heads/master","pushedAt":"2024-04-25T17:08:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types, types2: simplify Default function\n\nChange-Id: Ie2b7c1324ec7947c6ff43187dda99b83bcb64f08\nReviewed-on: https://go-review.googlesource.com/c/go/+/581775\nReviewed-by: Robert Findley \nReviewed-by: Robert Griesemer \nAuto-Submit: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/types, types2: simplify Default function"}},{"before":"8960925ad8dd1ef234731d94ebbea263e35a3e42","after":"8c0da423f77fff5e206ad777cfc496e935cb3af6","ref":"refs/heads/master","pushedAt":"2024-04-25T16:06:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: go env GOMOD should not download newer toolchain\n\nIt is not neccessary to download a newer toolchain to display the path\nto GOMOD or GOWORK.\n\nFixes: #61455\n\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest\nChange-Id: I0b031651ad9bfeb5565361ecaff6908640ccf9c8\nReviewed-on: https://go-review.googlesource.com/c/go/+/581275\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"cmd/go: go env GOMOD should not download newer toolchain"}},{"before":"db5f2b415399da9b653e68aa03f23ce661cc5339","after":"8960925ad8dd1ef234731d94ebbea263e35a3e42","ref":"refs/heads/master","pushedAt":"2024-04-25T11:29:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"time: deflake TestChan/asynctimerchan=1 tests\n\nThe overall time package tests increase from 3.85s to 4.85s on my laptop.\nBut they should be less flaky, and the time is spent sleeping, so it won't\nslow down the overall machine running multiple package tests in\nparallel.\n\nFor #66322.\n\nChange-Id: I66d6647c389c943b53045e8836ede4ba3d4670c7\nReviewed-on: https://go-review.googlesource.com/c/go/+/581315\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"time: deflake TestChan/asynctimerchan=1 tests"}},{"before":"4351af68eb053973f8782bf1514358e4a8d1ab00","after":"db5f2b415399da9b653e68aa03f23ce661cc5339","ref":"refs/heads/master","pushedAt":"2024-04-25T01:05:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"spec: clarify when a range expression is evaluated\n\nIf the range expression is a numeric constant, the\nrange expression is also not evaluated.\n\nChange-Id: I97201e5c136d3d1a87ed1500b19b7199b30bc9ff\nReviewed-on: https://go-review.googlesource.com/c/go/+/581298\nReviewed-by: Robert Griesemer \nReviewed-by: Ian Lance Taylor \nTryBot-Bypass: Robert Griesemer \nAuto-Submit: Robert Griesemer ","shortMessageHtmlLink":"spec: clarify when a range expression is evaluated"}},{"before":"e7aeeae0c89f5bae76ba263b1ab2b82c56ad32a3","after":"4351af68eb053973f8782bf1514358e4a8d1ab00","ref":"refs/heads/master","pushedAt":"2024-04-25T01:02:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net/http: improve continue statements for tests\n\nChange-Id: I302368c17fbb6983bd14ab72784076e548ed8829\nReviewed-on: https://go-review.googlesource.com/c/go/+/581475\nAuto-Submit: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Damien Neil \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"net/http: improve continue statements for tests"}},{"before":"799968dfc3b9121019b752a9110489baa71a4355","after":"e7aeeae0c89f5bae76ba263b1ab2b82c56ad32a3","ref":"refs/heads/master","pushedAt":"2024-04-25T00:47:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"image/jpeg: ignore garbage bytes before a RST marker\n\nWell-formed JPEG images will not have garbage bytes. However, for\ncorrupted JPEG images, the RST (restart) mechanism is specifically\ndesigned so that a decoder can re-synchronize to an upcoming restartable\nMCU (Minimum Coded Unit, e.g. 16x16 block of pixels) boundary and resume\ndecoding. Even if the resultant image isn't perfect, a 98%-good image is\nbetter than a fatal error.\n\nEvery JPEG marker is encoded in two bytes, the first of which is 0xFF.\nThere are 8 possible RST markers, cycling as \"0xFF 0xD0\", \"0xFF 0xD1\",\n..., \"0xFF 0xD7\". Suppose that, our decoder is expecting \"0xFF 0xD1\".\n\nBefore this commit, Go's image/jpeg package would accept only two\npossible inputs: a well-formed \"0xFF 0xD1\" or one very specific pattern\nof spec non-compliance, \"0xFF 0x00 0xFF 0xD1\".\n\nAfter this commit, it is more lenient, similar to libjpeg's jdmarker.c's\nnext_marker function.\nhttps://github.com/libjpeg-turbo/libjpeg-turbo/blob/2dfe6c0fe9e18671105e94f7cbf044d4a1d157e6/jdmarker.c#L892-L935\n\nThe new testdata file was created by:\n\n$ convert video-001.png a.ppm\n$ cjpeg -restart 2 a.ppm > video-001.restart2.jpeg\n$ rm a.ppm\n\nFixes #40130\n\nChange-Id: Ic598a5f489f110d6bd63e0735200fb6acac3aca3\nReviewed-on: https://go-review.googlesource.com/c/go/+/580755\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Joedian Reid ","shortMessageHtmlLink":"image/jpeg: ignore garbage bytes before a RST marker"}},{"before":"9b9de261bd66333885adb7b36f1dd133d00cfe13","after":"799968dfc3b9121019b752a9110489baa71a4355","ref":"refs/heads/master","pushedAt":"2024-04-25T00:44:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.types, types2: factor out isUntypedNumeric predicate\n\nNo need for Unalias or under calls for this predicate.\n\nChange-Id: Idcdcda3e153d829ee5b26ad112ccfda3f4efedde\nReviewed-on: https://go-review.googlesource.com/c/go/+/581255\nReviewed-by: Robert Griesemer \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Griesemer ","shortMessageHtmlLink":"go.types, types2: factor out isUntypedNumeric predicate"}},{"before":"e689118852c9c1841ee4c17aeeb3ec3a5242e9a2","after":"9b9de261bd66333885adb7b36f1dd133d00cfe13","ref":"refs/heads/master","pushedAt":"2024-04-24T21:50:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types: add Alias.Rhs\n\nThis method returns the type on the right-hand side of an\nalias declaration such as type L = R.\n\nFixes #66559\n\nChange-Id: I396f2d999680ad251f47cdde20856ae20fc1c40a\nReviewed-on: https://go-review.googlesource.com/c/go/+/581615\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan \nReviewed-by: Robert Griesemer ","shortMessageHtmlLink":"go/types: add Alias.Rhs"}},{"before":"d037bba19b26064dcbd19be2c17e042c8d421f2c","after":"e689118852c9c1841ee4c17aeeb3ec3a5242e9a2","ref":"refs/heads/master","pushedAt":"2024-04-24T18:16:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"crypto/tls: skip bogo suite on windows builders\n\nUpdates #66913\n\nChange-Id: Ie6bb262ee95593d23a93ef06656a561a7b1006ba\nReviewed-on: https://go-review.googlesource.com/c/go/+/581515\nAuto-Submit: Roland Shoemaker \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"crypto/tls: skip bogo suite on windows builders"}},{"before":"3aad2d0765b9f652e1964a8261d6ef0035d9535f","after":"d037bba19b26064dcbd19be2c17e042c8d421f2c","ref":"refs/heads/master","pushedAt":"2024-04-24T15:55:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: add debug log prior to export data lookup\n\nIf there is a crash in LookupFunc (which has occurred a few times now),\nthis ensures that we log the offending symbol before crashing.\n\nFor #67016.\n\nChange-Id: I0119597de2be3d1b97c41a9361273d1feb90ec11\nReviewed-on: https://go-review.googlesource.com/c/go/+/581437\nReviewed-by: Cherry Mui \nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/compile: add debug log prior to export data lookup"}},{"before":"4792ca7b93d5745647a95ac73a93f9c9b97db499","after":"3aad2d0765b9f652e1964a8261d6ef0035d9535f","ref":"refs/heads/master","pushedAt":"2024-04-24T15:54:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/internal/obj/ppc64: fix incorrect int to int64 conversion when checking MOVD opcodes\n\nA type conversion from int to int64 was done in the wrong place causing\nsome MOVD $const, Rx operations to be incorrectly transformed on 32 bit\nhosts cross-compiling for ppc64x.\n\nFixes #66955\n\nChange-Id: I023ba267a8dac6d6bd22f8146c0d9d2d473bc5c1\nReviewed-on: https://go-review.googlesource.com/c/go/+/580796\nReviewed-by: Mauri de Souza Meneguzzo \nReviewed-by: Joedian Reid \nReviewed-by: Lynn Boger \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/internal/obj/ppc64: fix incorrect int to int64 conversion when ch…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEO8zr7wA","startCursor":null,"endCursor":null}},"title":"Activity · golang/go"}