Round scale to nearest 26.6 fixed point. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, the computation of the scale factor becomes identical across the freetype and truetype packages, removing deviations in the font metrics that are derived from scale. The rounding computation is newer; it was introduced when the truetype.Face type was added in commit 6deea24. Fixes #85.
|
I just noticed there's a return fixed.Int26_6(x * float64(c.dpi) * (64.0 / 72.0))We should not change one without also changing the other, as that would fix #85 but introduce another inconsistency within this package. Hmm. |
Otherwise there may be deviations between the scale computation and the conversion done by PointToFixed in the same package.
Yeah, that's unfortunate. :-/ |
|
applied this to https://github.com/goki/freetype |
rcoreilly
added a commit
to goki/freetype
that referenced
this pull request
Mar 28, 2023
…inding = true in rasterizer; return !ok in GlyphAdvance if rune index == 0, consistent with opentype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the computation of the scale factor becomes
identical across the freetype and truetype packages, removing
deviations in the font metrics that are derived from scale.
Apply the same change to the Context.PointToFixed method to
keep it in sync.
The rounding computation is newer; it was introduced when the
truetype.Face type was added in commit 6deea24.
Fixes #85.