{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":41456526,"defaultBranch":"master","name":"arch","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-08-27T00:28:32.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714834936.0","currentOid":""},"activityList":{"items":[{"before":"a85057043824df19248fb9070bc44f3403f8876e","after":"5d0b1102bee052ce00bf47f9cfef8f73d2ac6d46","ref":"refs/heads/master","pushedAt":"2024-04-16T17:17:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"x86/x86asm: fix function name in comment\n\nChange-Id: Ie70c842161c96948098082d3c0ff1b026bcfd8de\nReviewed-on: https://go-review.googlesource.com/c/arch/+/579198\nReviewed-by: qiu laidongfeng2 <2645477756@qq.com>\nLUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>\nReviewed-by: Ian Lance Taylor <iant@google.com>\nTryBot-Result: Gopher Robot <gobot@golang.org>\nReviewed-by: Cherry Mui <cherryyz@google.com>\nAuto-Submit: Ian Lance Taylor <iant@google.com>\nCommit-Queue: Ian Lance Taylor <iant@google.com>\nRun-TryBot: shuang cui <imcusg@gmail.com>","shortMessageHtmlLink":"x86/x86asm: fix function name in comment"}},{"before":"a6bdeed4930798f0aa566beb7883ab0d88dc9646","after":"a85057043824df19248fb9070bc44f3403f8876e","ref":"refs/heads/master","pushedAt":"2023-12-06T20:22:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"x86avxgen/testdata/xedpath: replace \"INTEL CONFIDENTIAL\" files\n\nThese files are not really confidential - they were released in\ngithub.com/intelxed/xed with incorrect copyright notices.\nThe copyright notices were updated in\nhttps://github.com/intelxed/xed/commit/5c538047876feecf080d9441110f81d0e67b5de8\nbut the files had also changed a bit by then.\n\nReplace the two mislabeled files with the latest versions,\nbringing in the updated Apache license as well as assorted other changes.\nThe tests still pass, so these changes must not matter too much.\n\nFixes golang/go#64315.\n\n[git-generate]\n\ncd x86/x86avxgen/testdata/xedpath\n\nrm -rf _xed\ngit clone https://github.com/intelxed/xed _xed\ncd _xed\ngit checkout d41e876  # \"2019 copyright\"\ncd ..\n\necho '\ne all-dec-instructions.txt\n/^###FILE:.*avx512-foundation-isa.xed.txt/+1;/^###FILE/-3 d\n/^###FILE:.*avx512-foundation-isa.xed.txt/+1r _xed/datafiles/avx512f/avx512-foundation-isa.xed.txt\n/^###FILE:.*skx-isa.xed.txt/+1;/^###FILE/-3 d\n/^###FILE:.*skx-isa.xed.txt/+1r _xed/datafiles/avx512-skx/skx-isa.xed.txt\n,s/ +$//g\nw\nq\n' | sam -d\n\nChange-Id: I60fb4b9a420b8962fbbdd026cb6229d55144908d\nReviewed-on: https://go-review.googlesource.com/c/arch/+/547775\nLUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>\nReviewed-by: Cherry Mui <cherryyz@google.com>","shortMessageHtmlLink":"x86avxgen/testdata/xedpath: replace \"INTEL CONFIDENTIAL\" files"}},{"before":"05c9512268b810910595e592c68436f27594f3c1","after":"a6bdeed4930798f0aa566beb7883ab0d88dc9646","ref":"refs/heads/master","pushedAt":"2023-10-11T14:13:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"arm/armspec: remove obsolete comment\n\nI didn't realize it at the time, but this comment was referring\nto the build constraint that was removed in CL 534197.\n\nUpdates golang/go#12840.\n\nChange-Id: I1e6694a6c05f4b2e6dbffe6488c69f9d530bdaf4\nReviewed-on: https://go-review.googlesource.com/c/arch/+/534221\nAuto-Submit: Dmitri Shuralyov <dmitshur@golang.org>\nLUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>\nReviewed-by: Dmitri Shuralyov <dmitshur@google.com>\nReviewed-by: Cherry Mui <cherryyz@google.com>","shortMessageHtmlLink":"arm/armspec: remove obsolete comment"}},{"before":"b6e875325b9240a588005b57569516391c352e78","after":"05c9512268b810910595e592c68436f27594f3c1","ref":"refs/heads/master","pushedAt":"2023-10-10T23:22:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: update go directive to 1.18\n\nDone with:\n\ngo get go@1.18\ngo mod tidy\ngo fix ./...\n\nUsing go1.21.3.\n\nAlso delete the build constraints that are always satisfied\nwhen using supported Go versions.\n\nFor golang/go#60268.\n\nChange-Id: Iab4a7237a368b1ac05bb72a646501defb51503f1\nReviewed-on: https://go-review.googlesource.com/c/arch/+/534197\nReviewed-by: Cherry Mui <cherryyz@google.com>\nLUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>\nReviewed-by: Dmitri Shuralyov <dmitshur@google.com>\nAuto-Submit: Dmitri Shuralyov <dmitshur@golang.org>","shortMessageHtmlLink":"all: update go directive to 1.18"}},{"before":"060bf14d30f8a6b2e19c8aab764c104725b1682f","after":"b6e875325b9240a588005b57569516391c352e78","ref":"refs/heads/master","pushedAt":"2023-08-21T18:18:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: gofmt format\n\nChange-Id: Iaea9ce0d3b237123cdb4315790960aeee1b13a80\nReviewed-on: https://go-review.googlesource.com/c/arch/+/520577\nRun-TryBot: shuang cui <imcusg@gmail.com>\nAuto-Submit: Ian Lance Taylor <iant@golang.org>\nReviewed-by: Cherry Mui <cherryyz@google.com>\nTryBot-Result: Gopher Robot <gobot@golang.org>\nReviewed-by: Bryan Mills <bcmills@google.com>","shortMessageHtmlLink":"all: gofmt format"}},{"before":"40c19ba4a7c5ffc92baaef5977ffc2b82dfb0e47","after":"060bf14d30f8a6b2e19c8aab764c104725b1682f","ref":"refs/heads/internal-branch.go1.21-vendor","pushedAt":"2023-07-17T16:36:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"x86asm: disassemble CMP instruction's arguments in the opposite order\n\nThat way it matches what the compiler's -S flag generates, and what we write\nin assembly.\n\n  CMP AX, $16\n  JLE foo\n\nshould get to foo if AX <= 16. Without this CL, the disassembly looks like\n\n  CMP $16, AX\n  JLE foo\n\nwhich reads like we should get to foo if 16 <= AX, which is not what these\ntwo instructions actually do.\n\nIt was originally this way because the CMP instruction parallels the SUB\ninstruction, except it throws away the non-flags result. We write that\nsubtraction as\n\n  SUB $16, AX  // AX <- AX-16\n\nbut we don't need to match the SUB's disassembly order, as CMP is not\nwriting to a register output.\n\nUpdate golang/go#60920\n(This fixes the underlying issue, but the actual \"fixes\" comment needs to go\non the CL that vendors x/arch containing this CL into the main branch.)\n\nChange-Id: Ifa8d3878453d6e33ae144bfdb01b34171c2106a1\nReviewed-on: https://go-review.googlesource.com/c/arch/+/505375\nReviewed-by: Cherry Mui <cherryyz@google.com>\nRun-TryBot: Keith Randall <khr@golang.org>\nTryBot-Result: Gopher Robot <gobot@golang.org>\nReviewed-by: Keith Randall <khr@google.com>","shortMessageHtmlLink":"x86asm: disassemble CMP instruction's arguments in the opposite order"}},{"before":"40c19ba4a7c5ffc92baaef5977ffc2b82dfb0e47","after":"060bf14d30f8a6b2e19c8aab764c104725b1682f","ref":"refs/heads/master","pushedAt":"2023-07-03T19:24:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"x86asm: disassemble CMP instruction's arguments in the opposite order\n\nThat way it matches what the compiler's -S flag generates, and what we write\nin assembly.\n\n  CMP AX, $16\n  JLE foo\n\nshould get to foo if AX <= 16. Without this CL, the disassembly looks like\n\n  CMP $16, AX\n  JLE foo\n\nwhich reads like we should get to foo if 16 <= AX, which is not what these\ntwo instructions actually do.\n\nIt was originally this way because the CMP instruction parallels the SUB\ninstruction, except it throws away the non-flags result. We write that\nsubtraction as\n\n  SUB $16, AX  // AX <- AX-16\n\nbut we don't need to match the SUB's disassembly order, as CMP is not\nwriting to a register output.\n\nUpdate golang/go#60920\n(This fixes the underlying issue, but the actual \"fixes\" comment needs to go\non the CL that vendors x/arch containing this CL into the main branch.)\n\nChange-Id: Ifa8d3878453d6e33ae144bfdb01b34171c2106a1\nReviewed-on: https://go-review.googlesource.com/c/arch/+/505375\nReviewed-by: Cherry Mui <cherryyz@google.com>\nRun-TryBot: Keith Randall <khr@golang.org>\nTryBot-Result: Gopher Robot <gobot@golang.org>\nReviewed-by: Keith Randall <khr@google.com>","shortMessageHtmlLink":"x86asm: disassemble CMP instruction's arguments in the opposite order"}},{"before":null,"after":"40c19ba4a7c5ffc92baaef5977ffc2b82dfb0e47","ref":"refs/heads/internal-branch.go1.21-vendor","pushedAt":"2023-06-14T17:54:49.508Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix some comments\n\nChange-Id: Ic196f7a97e423708d0a86ff8da99871e966dc2fc\nReviewed-on: https://go-review.googlesource.com/c/arch/+/466000\nRun-TryBot: Ian Lance Taylor <iant@google.com>\nReviewed-by: Ian Lance Taylor <iant@google.com>\nReviewed-by: David Chase <drchase@google.com>\nAuto-Submit: Ian Lance Taylor <iant@google.com>\nTryBot-Result: Gopher Robot <gobot@golang.org>","shortMessageHtmlLink":"all: fix some comments"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEMkUdugA","startCursor":null,"endCursor":null}},"title":"Activity · golang/arch"}