Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repositories named '..' and '.' cannot be entered. #3229

Closed
2 of 6 tasks
tmplt opened this issue Jul 3, 2016 · 3 comments
Closed
2 of 6 tasks

Repositories named '..' and '.' cannot be entered. #3229

tmplt opened this issue Jul 3, 2016 · 3 comments
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Milestone
0.10.0

Comments

@tmplt
Copy link

tmplt commented Jul 3, 2016

  • Gogs version (or commit ref): 0.9.13
  • Git version: 2.9.0
  • Operating system: Arch Linux
  • Database:
    • PostgreSQL
    • MySQL
    • SQLite
  • Can you reproduce the bug at http://try.gogs.io:
  • Log gist: I was unable to find a log which mentioned the created repositories.

Description

If I create a repository named .. or ., trying to enter them will instead direct me to git.hostname.tld, respectively git.hostname.tld/<repo owner>.

These repositories can, however, be pushed to with git.
@unknwon
Copy link
Member

unknwon commented Jul 4, 2016

Hi, I think it is browser's automatic behavior, should we disable such names?

@unknwon unknwon added the status: needs feedback Tell me more about it label Jul 4, 2016
@bkcsoft
Copy link
Contributor

bkcsoft commented Jul 4, 2016 via email

@unknwon unknwon added 🔨 enhancement Make it better, faster and removed status: needs feedback Tell me more about it labels Jul 7, 2016
@unknwon unknwon added this to the 0.10.0 milestone Jul 7, 2016
@unknwon unknwon added the status: needs feedback Tell me more about it label Jul 7, 2016
unknwon added a commit that referenced this issue Jul 7, 2016
@unknwon
#3229 disallow repository name . and ..
e30c701 
Since . and .. has browser automatical behaviors, we need to disallow those names.
@unknwon
Copy link
Member

unknwon commented Jul 7, 2016

It's now fixed on develop branch.

@unknwon unknwon closed this as completed Jul 10, 2016
ethantkoenig pushed a commit to ethantkoenig/gogs that referenced this issue Feb 6, 2018
@uncled1023 @lafriks
Fixed missing end tag for organization link (gogs#3229)
5332052
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
3 participants
@unknwon @bkcsoft @tmplt