Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default and Overridable Request Timeout #600

Closed
aryanmehrotra opened this issue May 13, 2024 · 2 comments
Closed

Default and Overridable Request Timeout #600

aryanmehrotra opened this issue May 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request Service Related to external http, grpc communciation , middlewares etc.

Comments

@aryanmehrotra
Copy link
Contributor

Currently, request waits for 30 seconds before timing out, which should be less to about 5 seconds or user should be able to override.

image
@aryanmehrotra aryanmehrotra added the enhancement New feature or request label May 13, 2024
@Umang01-hash Umang01-hash added Service Related to external http, grpc communciation , middlewares etc. labels May 13, 2024
@Umang01-hash Umang01-hash mentioned this issue May 17, 2024
4 tasks
@KedarisettiSreeVamsi
Copy link

KedarisettiSreeVamsi commented May 19, 2024

Hi @Umang01-hash, I have just gone through the PR and I think we can use the context itself to set a timeout rather than explicitly mentioning a timeout parameter for the function.

I am linking to a video from one of the channel where he mentioned that using context timeout is better than using a explicit timeout. Sorry if it is not a good suggestion.

Link: https://youtu.be/PCgnBCE-N8I?si=zEY19aawdKC4EbCb

Checkout after 13 minutes and 14 seconds.

@Umang01-hash
Copy link
Contributor

Hi @Umang01-hash, I have just gone through the PR and I think we can use the context itself to set a timeout rather than explicitly mentioning a timeout parameter for the function.

I am linking to a video from one of the channel where he mentioned that using context timeout is better than using a explicit timeout. Sorry if it is not a good suggestion.

Link: https://youtu.be/PCgnBCE-N8I?si=zEY19aawdKC4EbCb

Checkout after 13 minutes and 14 seconds.

Surely @KedarisettiSreeVamsi I was also planning to use context timeouts after the initial implementation of server timeout. Will update the code. Thanks for the video!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Service Related to external http, grpc communciation , middlewares etc.
Projects
None yet
Development

No branches or pull requests

3 participants