Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of clarity around MaxConcurrency in README #212

Open
dan-pulley opened this issue Mar 31, 2022 · 0 comments
Open

Lack of clarity around MaxConcurrency in README #212

dan-pulley opened this issue Mar 31, 2022 · 0 comments

Comments

@dan-pulley
Copy link

The readme specifies "a new job will not be scheduled if we are at or over a job's MaxConcurrency limit."

https://github.com/gocraft/work#job-concurrency

However the code implies the job will still be inserted, it just won't be selected or run.

work/redis.go

Line 107 in 5959e69

var redisLuaFetchJob = fmt.Sprintf(`

It appears that this is just an easily misread bit of text - I was concerned from the readme that the job would just fail to be created, but the code strongly seems to indicate that the job simply won't get worked on if we are over the concurrency limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant