Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests for invalid format items #193

Open
goatshriek opened this issue Oct 10, 2021 · 4 comments
Open

refactor tests for invalid format items #193

goatshriek opened this issue Oct 10, 2021 · 4 comments
Labels
help wanted external contributations encouraged refactor changes that require refactoring of existing code testing pertains to the test suite

Comments

@goatshriek
Copy link
Owner

Tests for names and other elements with formatting errors use much of the same code, and could be made more compact by refactoring the common code into helper test functions. Some documentation on creating and using test helpers can be found in test/README.md and docs/test.md

See the discussion of #184 for the context behind this request.

@goatshriek goatshriek added help wanted external contributations encouraged refactor changes that require refactoring of existing code labels Oct 10, 2021
@Marecek460
Copy link
Contributor

Hello. I would like to help work on this issue.

@goatshriek
Copy link
Owner Author

goatshriek commented Oct 27, 2021

Absolutely! I have assigned the issue to you to mark it as in work. This issue is admittedly a little vague, so please reach out if you have any questions or need clarification.

@goatshriek
Copy link
Owner Author

Hello @Marecek460, just checking to see if you still intend to work on this? No worries if not, just want to see if this should be released for others.

@goatshriek goatshriek added testing pertains to the test suite stale inactive issue or pull request labels Oct 3, 2022
@goatshriek goatshriek removed the stale inactive issue or pull request label Nov 16, 2022
@goatshriek
Copy link
Owner Author

This item is open for others to tackle once more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted external contributations encouraged refactor changes that require refactoring of existing code testing pertains to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants