Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring common portions of stumpless_param_to_string and stumpless_element_to_string #183

Open
northernSage opened this issue Jun 8, 2021 · 0 comments
Open

Refactoring common portions of stumpless_param_to_string and stumpless_element_to_string #183

northernSage opened this issue Jun 8, 2021 · 0 comments
Labels
help wanted external contributations encouraged refactor changes that require refactoring of existing code

Comments

@northernSage
Copy link
Contributor

This is just a follow up issue to improve on #180.

Quoting from #146:

You may consider refactoring some common portions of stumpless_param_to_string into separate private functions that can be used in both places for efficiency...

Since #180 did not implement the changes described above I'll go ahead and work on a separate PR for this. I have opened the issue only to document my intent in doing so and to have somewhere to discuss related changes if the need arises.
@goatshriek goatshriek added help wanted external contributations encouraged refactor changes that require refactoring of existing code labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted external contributations encouraged refactor changes that require refactoring of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goatshriek @northernSage