Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anything the community can do to help maintain this library? #261

Closed
tonglil opened this issue May 11, 2017 · 8 comments
Closed

Anything the community can do to help maintain this library? #261

tonglil opened this issue May 11, 2017 · 8 comments

Comments

@tonglil
Copy link

tonglil commented May 11, 2017

This yaml library seems to be the definitely library depended on by many Go packages.

Is there something the community can do to help merge fixes to various identified and confirmed issues @niemeyer?

@kevinburke
Copy link

triaging bugs would probably help, indicating issues that should be closed would help, performing code reviews on open issues would probably help

@niemeyer
Copy link
Contributor

Several weeks back I had a conversation with @rogpeppe and we agreed he'd allocate some of his time to keeping this library up-to-date and well taken care of. This seems to be taking slightly more time than expected to happen, though.

@rogpeppe Do you have any news there?

@nmiyake
Copy link

nmiyake commented May 18, 2017

Happy to do a pass on some of these things -- we make extensive use of this library and find it very valuable and would love to see some more movement on some of the open issues/PRs.

What's the best way to flag issues that should be closed? Is there someone I can @ to flag to who can close out things that are stale/resolved?

@samczsun samczsun mentioned this issue May 22, 2017
@balanatarajan
Copy link

@niemeyer What is the expected commitment for maintaining this? I can see whether someone in my team would be willing to help as well

@lox
Copy link

lox commented Mar 9, 2018

I'm happy to assist to. We make heavy use of it too.

@niemeyer
Copy link
Contributor

niemeyer commented Mar 9, 2018

@lox Help is always appreciated, and that's true of anything I have some involved on.

The best way to help is to engage and perform tasks that other long term maintainers would otherwise have to sit down and dedicate spans of time to do. Once the PR is ready for merging, it's easy to click on the button.

For example, I see you have interest on #220. This PR has a large number of changes that are completely unrelated to fixing a bug. It doesn't even describe what the problem is, although I can see that there's clearly a problem and that other people agree, which means we want to merge something. So, valuable work includes:

  • Reviewing code, looking for potential issues
  • Separating related changes from unrelated changes
  • Ensuring all the changes are well tested
  • Ensuring we're following established conventions from Go
  • Finding what the conventions are in the first place (no matter how experienced, following patterns involves looking for them too)
  • Recommending actions (closing bugs)

Hope that helps a bit.

As a side note, I'm working on yaml.v3 right now. Some major improvements coming.

@niemeyer niemeyer closed this as completed Mar 9, 2018
@lox
Copy link

lox commented Mar 10, 2018

I'll see what I can do!

@niemeyer
Copy link
Contributor

Thanks @lox, and welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants