Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show summary of reviews #4390

Closed
jonasfranz opened this issue Jul 6, 2018 · 3 comments · Fixed by #5132
Closed

Show summary of reviews #4390

jonasfranz opened this issue Jul 6, 2018 · 3 comments · Fixed by #5132
Labels
type/enhancement An improvement of existing functionality
Milestone
1.7.0

Comments

@jonasfranz
Copy link
Member

Code reviews should be shown at the sidebar of a pull request like GitHub does.

Blocked by #3748
@jonasfranz jonasfranz added type/enhancement An improvement of existing functionality status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Jul 6, 2018
@jonasfranz jonasfranz added this to the 1.6.0 milestone Jul 6, 2018
@lafriks
Copy link
Member

lafriks commented Jul 6, 2018

I would prefer them to be shown just before merge button. Sidebar is getting too crowded

@jonasfranz jonasfranz changed the title Show reviews at the sidebar Show summary of reviews Jul 7, 2018
@lunny
Copy link
Member

lunny commented Jul 8, 2018

I would like @lafriks' idea. Github also show all reviewers before merge button. But github shows suggest reviewers on sidebar.

@jonasfranz jonasfranz removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Aug 6, 2018
@jonasfranz
Copy link
Member Author

#3748 got implemented! Ready to get implemented.

@lunny lunny modified the milestones: 1.6.0, 1.7.0 Sep 7, 2018
@kolaente kolaente mentioned this issue Oct 20, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Show review summary in pull requests kolaente/gitea
3 participants
@lunny @lafriks @jonasfranz