passwords with spaces seem to fail?

[internalfx]

• Gitea version (or commit ref): 1.4.2
• Git version:
• Operating system: Ubuntu 18.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

If your postgres password contains a space, gitea will not install.

Screenshots

[bkcsoft]

gitea/models/models.go

Lines 216 to 223 in 85414d8

	case "postgres":
	host, port := parsePostgreSQLHostPort(DbCfg.Host)
	if host[0] == '/' { // looks like a unix socket
	connStr = fmt.Sprintf("postgres://%s:%s@:%s/%s%ssslmode=%s&host=%s",
	url.QueryEscape(DbCfg.User), url.QueryEscape(DbCfg.Passwd), port, DbCfg.Name, Param, DbCfg.SSLMode, host)
	} else {
	connStr = fmt.Sprintf("postgres://%s:%s@%s:%s/%s%ssslmode=%s",
	url.QueryEscape(DbCfg.User), url.QueryEscape(DbCfg.Passwd), host, port, DbCfg.Name, Param, DbCfg.SSLMode)

QueryEscape should be PathEscape 🙂

[lunny]

@bkcsoft could you send a PR to fix that?

[techknowlogick]

@lunny / @bkcsoft I've just sent a PR for this at #4275 Please review.