Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive UI #35

Closed
tboerger opened this issue Nov 3, 2016 · 47 comments · Fixed by #2750
Closed

Responsive UI #35

tboerger opened this issue Nov 3, 2016 · 47 comments · Fixed by #2750
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Milestone

Comments

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

We should provide a responsive UI on best afford. The best way should be a separate view like it's done on gitHub, but on the short term we could simply provide repsonsive elements to give a good view also on mobile devices.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.1.0 milestone Nov 3, 2016
@jeppech
Copy link

jeppech commented Nov 3, 2016

If a new web framework is to be considered, I'd like to suggest Bulma. It's based on flexbox, and easy to work with.

@joubertredrat
Copy link
Contributor

I used Bulma too and liked too, but I liked current design too, We can consider responsive design, but I think that can be on future.

@tboerger
Copy link
Member Author

tboerger commented Nov 3, 2016

I think we can stay with the current framework, we just need to enable responsive definitions.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 3, 2016

Semantic is really easy to make responsive, so no need to switch frameworks.
Personally I'd just update one view at a time to make it responsive, instead of copying and rewriting the entire site. What way we also get "small" fixes that can easily be reviewed 🙂

@lunny
Copy link
Member

lunny commented Nov 3, 2016

Change UI is a heavily work. I prefer @tboerger's idea. And for mobile user, I think make an android and an ios project to satisfy them. We can do this work base on some open source github clients's work.

@tboerger tboerger added the topic/ui Change the appearance of the Gitea UI label Nov 3, 2016
@jhasse
Copy link

jhasse commented Nov 3, 2016

The best way should be a separate view like it's done on gitHub, but on the short term we could simply provide repsonsive elements to give a good view also on mobile devices.

I actually think that responsive designs are better than separate mobile views. I hate that I can't do everything with the mobile view on GitHub.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 3, 2016

I agree with @jhasse

@YamiOdymel
Copy link

YamiOdymel commented Feb 13, 2017

I have experience with Semantic UI before. I tried to make everything stackable, and I also adjust some of the offsets. But the final result is not good.

There're too many tricky hacks and the !important flags, floating elements in the current styles. The layout were all designed for the desktop (without thinking about to support the mobile in the future).

There're not much elements, modules can be used in Bulma currently. Semantic UI has a lot of the components, modules already. But there's no hamburger menu in Semantic UI, we will need a sidebar for the nav menu.

I would suggest to rebuild another layout with Semantic UI and make it mobile-friendly in the future.

screen shot 2017-02-14 at 12 20 00 am
screen shot 2017-02-13 at 11 58 30 pm
screen shot 2017-02-14 at 1 23 27 am
screen shot 2017-02-14 at 12 36 40 am
screen shot 2017-02-14 at 12 13 09 am

@bkcsoft
Copy link
Member

bkcsoft commented Feb 14, 2017

Well, if it is to be rewritten entirely, why not replace it with bootstrap? And themes while we're at it :trollface:

@lunny
Copy link
Member

lunny commented Feb 15, 2017

@bkcsoft the old version of Gogs is bootstrap. then bootstrap -> semantic UI -> bootstrap ...

@bkcsoft
Copy link
Member

bkcsoft commented Feb 15, 2017

well, if it doesn't work you switch ;)

@joubertredrat
Copy link
Contributor

joubertredrat commented Feb 15, 2017

I think that is bad idea to change from Semantic UI to bootstrap, maybe Bulma if want to write new interface to have visual different from Gogs and support responsive, but I think that is good idea to make this more ahead

@YamiOdymel
Copy link

YamiOdymel commented Feb 15, 2017

I'll suggest to stay with Semantic UI. There're many modules can be used in Semantic UI already, for example the Dropdown (which is used in Gitea for creating the repos).

screen shot 2017-02-15 at 7 46 01 pm

But Bootstrap doesn't come with the modules, you would have to search for the modules with Google. And some of the module styles were designed for the Bootstrap original style.

Which means if you changed the theme of Bootstrap, the module styles would still stay with the original Bootstrap theme. (ex: Bootstrap Toggle)

screen shot 2017-02-15 at 7 50 04 pm

@ptman
Copy link
Contributor

ptman commented Feb 15, 2017

The current problem is that the UI isn't terribly good on mobile. This is not a democracy where everyone gets a say in how it cannot be solved. If somebody contributes a fix that works better than the current on both desktop and mobile then it can be merged. No matter if it's using bootstrap or semantic or something else. If you want Semantic to win, contribute a better solution using Semantic.

@YamiOdymel
Copy link

@ptman Even if it's a totally-different-design can also be merged?

@ptman
Copy link
Contributor

ptman commented Feb 15, 2017

@YamiOdymel not up to me, up to the maintainers

@joubertredrat
Copy link
Contributor

Little conception question, is really necessary to set layout as responsive? I talked with all my friends and community that I'm in and no one talked that use smartphone for access code, issues or another information on github or gitlab.

I think that is better to make poll about this feature before implement at now

@jhasse
Copy link

jhasse commented Feb 15, 2017

If you don't use your smartphone for accessing Gitea, why do you care at all if this was implemented or not?

@joubertredrat
Copy link
Contributor

@jhasse but this is the point, how to implement feature that will be not used? I'm not talking that don't be need to be implemented, the impression I'm having is that this is being treated as a priority.

Because this I'm making this question, is really necessary and is priority? Let's make now. Isn't? Let's make this on future.

@bkcsoft
Copy link
Member

bkcsoft commented Feb 22, 2017

My "vote" goes to not changing the design unless it's absolutely necessary 🙂

@evantbyrne
Copy link

evantbyrne commented Feb 25, 2017

In my opinion, usage of !important in the CSS is a lesser evil than having a broken mobile layout. Would the current maintainers be opposed to a PR with potentially heavy usage of !important?

@pgaskin
Copy link
Contributor

pgaskin commented Mar 14, 2017

#1253 improves the explore page for mobile.

@lunny
Copy link
Member

lunny commented Apr 6, 2017

This will be a long term issue. So I move it from v1.2.0 to v1.x.x.

@sondr3
Copy link
Contributor

sondr3 commented May 15, 2017

I've been toying around with an idea of having a go at rewriting the UI for Gitea in Bootstrap or Bulma or something similar. If anyone wants to talk about it or collaborate or something drop me a line, I think it'd be a fun challenge.

@ghost
Copy link

ghost commented Jun 2, 2017

We are heavy into development of SPAs using vue and bulma. So far it has worked out awesomely for us.
As for specialized design elements like dropdowns, we get around them by having either modals or list of tags based on selection from the html dropdowns.
And wonderfully this has worked wonders on mobile.

Anyways, I have been searching for documentation on APIs. I'm starting development on a separate PWA client. Care to join?

@jhasse
Copy link

jhasse commented Jun 6, 2017

We are heavy into development of SPAs

Is there an issue for this which I can downvote?

@bkcsoft
Copy link
Member

bkcsoft commented Jun 14, 2017

Yeah, I second not writing this as a SPA. We could have real-time elements, but all core functionality preferably should work without JS enabled.

@ghost
Copy link

ghost commented Jun 15, 2017

I am not asking the team to turn this into an SPA. That would be bad for the Open web in general.
But I rather would like to develop an independent SPA that could talk to gitea APIs.
And for that, having a good set of well-documented REST APIs would surely help a lot.

@lunny
Copy link
Member

lunny commented Jun 16, 2017

@BANG88
Copy link

BANG88 commented Jun 20, 2017

Thanks for provide the swagger api documents. Are the api is stable for production use ?

Thank you

@sapk
Copy link
Member

sapk commented Jun 20, 2017

@BANG88 It mostly follow github as reference for the api. I would say that it is stable and the most change made lately were adding new methods.

@BANG88
Copy link

BANG88 commented Jun 20, 2017

@sapk Thank you , I will check it out later

@lcges
Copy link

lcges commented Aug 31, 2017

Hello.
Have any decisions about framework?
I have already worked on:
Bootstrap >> Semantic-UI >> Bulma
Now works on Foundation. I think the Foundation is the best designed web framework.

@lafriks
Copy link
Member

lafriks commented Aug 31, 2017

I have used foundation few years ago in one project and somehow I did not like it, it was too much hassle to get things right. If changing I'm for Bulma+vuejs :)

@tboerger
Copy link
Member Author

tboerger commented Sep 1, 2017

I don't think that we will change the used css framework at all, this framework works pretty well for responsive uis, it just needs to be done properly. We can integrate vuejs for some dynamic parts step by step.

@jonasfranz
Copy link
Member

Bountysource

@thehowl
Copy link
Contributor

thehowl commented Oct 19, 2017

Is anyone working on this? I'd like to take a stab and try to at the very least use Semantic's responsive features and make what I can stackable.

@hellasteph
Copy link

I just added $25 to the bounty. I would really love to have this as I work on my mobile device often. Thank you!

@thehowl
Copy link
Contributor

thehowl commented Oct 20, 2017

In case you're following along on this: I published a draft of the changes I'm working on on #2750. Check it out and tell me if you'd like to see some changes, I'd really love feedback!

@lafriks lafriks modified the milestones: 1.x.x, 1.4.0 Dec 31, 2017
@lafriks
Copy link
Member

lafriks commented Dec 31, 2017

@lunny can this be closed already?

@lunny
Copy link
Member

lunny commented Dec 31, 2017

@lafriks I just merged #2750. And I think yes this issue has been resolved by #2750 except you have other idea.

@lafriks
Copy link
Member

lafriks commented Dec 31, 2017

@lunny that pull request implements only part of pages to be mobile but it's fine with me to close this, was just asking your opinion.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.