Fix various problems around projects board view #30696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/go
lunny
changed the title
silverwind
reviewed
Apr 25, 2024
silverwind
reviewed
Apr 25, 2024
Co-authored-by: silverwind <me@silverwind.io>
silverwind
reviewed
Apr 25, 2024
|
Not sure I like this pin to star change, star icon does seem a bit out of place here. |
But it's not suitable to use |
Co-authored-by: silverwind <me@silverwind.io>
|
Should users even have to care about "default column"? Seems like useless visual distraction to render that icon. Imho we should remove that concept entirely. What's the purpose a default column anyways? |
Yes, I agree to remove the default column concept but not this PR. The default column because of the absent feature #30617 |
Maybe then remove the unrelated change with the icon? |
wxiaoguang
force-pushed
the
lunny/fix_move_column
branch
from
9e5c420
to
ed67149
Compare
|
Rewritten and simplified. |
wxiaoguang
force-pushed
the
lunny/fix_move_column
branch
from
6993bbe
to
2dc43be
Compare
wxiaoguang
force-pushed
the
lunny/fix_move_column
branch
from
2dc43be
to
104c29b
Compare
Since this is a bug fix and will be backported to v1.22. So I think it's better to merge this one and then that one. |
yp05327
reviewed
May 7, 2024
silverwind
approved these changes
May 7, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
May 8, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 8, 2024
# The problem The previous implementation will start multiple POST requests from the frontend when moving a column and another bug is moving the default column will never be remembered in fact. # What's changed - [x] This PR will allow the default column to move to a non-first position - [x] And it also uses one request instead of multiple requests when moving the columns - [x] Use a star instead of a pin as the icon for setting the default column action - [x] Inserted new column will be append to the end - [x] Fix go-gitea#30701 the newly added issue will be append to the end of the default column - [x] Fix when deleting a column, all issues in it will be displayed from UI but database records exist. - [x] Add a limitation for columns in a project to 20. So the sorting will not be overflow because it's int8. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
7 tasks
GiteaBot
added
backport/done
lunny
added a commit
that referenced
this pull request
May 8, 2024
Backport #30696 by @lunny # The problem The previous implementation will start multiple POST requests from the frontend when moving a column and another bug is moving the default column will never be remembered in fact. # What's changed - [x] This PR will allow the default column to move to a non-first position - [x] And it also uses one request instead of multiple requests when moving the columns - [x] Use a star instead of a pin as the icon for setting the default column action - [x] Inserted new column will be append to the end - [x] Fix #30701 the newly added issue will be append to the end of the default column - [x] Fix when deleting a column, all issues in it will be displayed from UI but database records exist. - [x] Add a limitation for columns in a project to 20. So the sorting will not be overflow because it's int8. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 9, 2024
* giteaofficial/main: Add missing menu active item background back (go-gitea#30897) Fix misspelling of mergable (go-gitea#30896) Fix incorrect issue form (go-gitea#30881) Update issue indexer after merging a PR (go-gitea#30715) Fix various problems around projects board view (go-gitea#30696) Fix wrong transfer hint (go-gitea#30889) Remove obsolete monaco workaround (go-gitea#30893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The previous implementation will start multiple POST requests from the frontend when moving a column and another bug is moving the default column will never be remembered in fact.
What's changed
project_board_idfor newly created issue #30701 the newly added issue will be append to the end of the default column