Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD git notes on the /commit/{hash} page #30615

Open
bilogic opened this issue Apr 20, 2024 · 4 comments
Open

CRUD git notes on the /commit/{hash} page #30615

bilogic opened this issue Apr 20, 2024 · 4 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@bilogic
Copy link
Contributor

bilogic commented Apr 20, 2024

Feature Description

It would be great to attach notes to each commit, 1 key use case that started this request is the need to store code review notes.

git notes: https://git-scm.com/docs/git-notes

Screenshots

No response

@bilogic bilogic added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Apr 20, 2024
@lunny
Copy link
Member

lunny commented Apr 20, 2024

I think the git note will already be displayed there.

@bilogic
Copy link
Contributor Author

bilogic commented Apr 20, 2024

Oh? Is there a way to create a note?

@lunny
Copy link
Member

lunny commented Apr 20, 2024

Currently you can only create a note from git client and push to Gitea.

@bilogic
Copy link
Contributor Author

bilogic commented Apr 21, 2024

Ok, so my feature request is to be able to (C)reate notes at /commit/{hash}, as many I interacted with have not heard of git notes before, e.g. mhutchie/vscode-git-graph#475 (comment)

In my view, gitea is a better place to create notes as the code has been pushed (and free from any uncommited/unpushed modifications) and it is also easier to ensure we have the same view via the URL when doing reviews through only voice without screen sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants