Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array_not_Matrix: uniop_bool_helper may not work with Array #1225

Open
cbm755 opened this issue Sep 2, 2022 · 2 comments
Open

Array_not_Matrix: uniop_bool_helper may not work with Array #1225

cbm755 opened this issue Sep 2, 2022 · 2 comments
Labels

Comments

@cbm755
Copy link
Collaborator

cbm755 commented Sep 2, 2022

this code:

              'if x if not None and x.is_Matrix:'
              '    return x.applyfunc(sf, *pp)'

Will need fixes something like #1224 for the is_Matrix part. But its also possible the .applyfunc bit will need to go through @alexvong243f's make_matrix_or_array.

I should do some experiments in SymPy: what is supposed to happen if you start with a Matrix and then .applyfunc your way to non-Expr entries?

@cbm755
Copy link
Collaborator Author

cbm755 commented Sep 2, 2022

Related upstream question: sympy/sympy#24008

@cbm755
Copy link
Collaborator Author

cbm755 commented Sep 4, 2022

Based on upstream comments, we should assume that .applyfunc would return a TypeError or similar if it produces something that cannot go back into a matrix.

I guess we catch that and try again with a loop and an Array? Might easiest to leave this until we can get that error from SymPy...

@cbm755 cbm755 added the longterm label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant