Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Compute and display SHA-256 of tarballs in make release #1208

Open
alexvong243f opened this issue Aug 12, 2022 · 2 comments
Open

Comments

@alexvong243f
Copy link
Collaborator

We should compute and display SHA-256 hashes of tarballs in make release and make it clear that MD5 is unsafe and for compatibility only. I think we should keep all the MD5 hashes for now to avoid any compatibility issues related to sourceforge. But after sourceforge is retired, it should be safe to remove all uses of MD5.

HOWTO-release.md should also be updated accordingly.

Related to #1180.

@alexvong243f alexvong243f changed the title Makefile: Compute and display SHA-256 of tarballs in Makefile Makefile: Compute and display SHA-256 of tarballs in make release Aug 12, 2022
@cbm755
Copy link
Collaborator

cbm755 commented Aug 12, 2022

Sounds good but I'm not sure how much of the pkg install -forge routines use md5 and those are still in use back to Octave 4 or something like that. So thread lightly and keep both!

@alexvong243f
Copy link
Collaborator Author

Sure, we should wait long enough and test throughly before removing any legacy stuff.

Also, we should investigate whether upstream is still using legacy hash functions such as MD5 or SHA-1 and fix it accordingly. For instance, help hash still uses MD5 and SHA-1 as the only examples, which isn't helpful if we want users not to use them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants