limit import path length

[thehowl]

From PR comment comment: #875 (comment)

We should limit the length of a package path. A limit like 128 or 256 characters sounds reasonable.

[r3v4s]

just to be sure, do we have code(or plan) that limits length of pkg_path when deploying package or realm ??

[thehowl]

@r3v4s we don't have any code yet that does it, this issue is about adding precisely that?

though I'm not sure I understood your question

[r3v4s]

@r3v4s we don't have any code yet that does it, this issue is about adding precisely that?

though I'm not sure I understood your question

You did understood perfectly. IMHO, rather than limiting the length to 128, I prefer setting it to 256 because it allows more leeway.

[thinhnx-var]

in case nobody gonna do this, I will take part in this issue. @thehowl

[thinhnx-var]

AFAIK, in oder to limit the total length of pkgPath with regex, we need the the look assertion like this

regexp.MustCompile(`^(?=.{0,256}$)gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+$`)

which is not currently supported in regexp

Im thinking about len(mempkg.Path) but maybe it effects the benchmarks.
What do you think? @r3v4s @thehowl

[r3v4s]

AFAIK, in oder to limit the total length of pkgPath with regex, we need the the look assertion like this

regexp.MustCompile(`^(?=.{0,256}$)gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+$`)

which is not currently supported in regexp

Im thinking about len(mempkg.Path) but maybe it effects the benchmarks. What do you think? @r3v4s @thehowl

It's shame that regexp doesn't support lookaheads. I really can't think of any option other than what you suggested(len(mempkg.Path)).

I'm worried about bench too, but shouldn't this length limit only applies to when we deploy contract(gnokey maketx addpkg) if it is, I don't think bench is going to be big problem