Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink the transient cache in Request Engine #236

Open
hrj opened this issue Jun 27, 2017 · 1 comment
Open

Rethink the transient cache in Request Engine #236

hrj opened this issue Jun 27, 2017 · 1 comment

Comments

@hrj
Copy link
Member

hrj commented Jun 27, 2017

The request engine maintains two types of caches: a transient (in memory) cache and a persistent (on disk) cache for cacheable responses.

The purpose of the transient cache is not clear to me. I think the disk cache should be sufficient as most OSes will cache the disk i/o anyway.

@oswetto seeking your help answering this one, in case you have figured it out in your fork of lobobrowser

@hrj
Copy link
Member Author

hrj commented Jun 28, 2017

There is a benefit in having a transient cache if the persistent cache is encrypted; the transient cache will help reduce the overhead of decryption for often used responses.

Note that the persistent cache is not currently encrypted, but it will be desirable to do so in the future.

Hence, it is better to keep the transient cache.

We can, however, redesign the cache system so that the distinction between transient and persistent caches is an internal implementation detail of the cache, rather than spreading the code throughout the request engine.

@hrj hrj changed the title Eliminate transient cache in Request Engine Rethink the transient cache in Request Engine Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant