Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchanting table is still not movable after enabling movableBlockEntities #1873

Open
ipg0 opened this issue Feb 18, 2024 · 2 comments
Open

Comments

@ipg0
Copy link

ipg0 commented Feb 18, 2024

The /carpet movableBlockEntities true command enables moving almost any block entity, but moving the enchanting table still fails. Is this a bug, or are there any extensions for this mod that would finally allow it?

@axialeaa
Copy link

This seems to be intentional, as there's a direct reference to enchanting tables being ignored in PistonBaseBlock_movableBEMixin#isPushableBlockEntity(Block):

private static boolean isPushableBlockEntity(Block block) {
    return block != Blocks.ENDER_CHEST && block != Blocks.ENCHANTING_TABLE && block != Blocks.END_GATEWAY && block != Blocks.END_PORTAL && block != Blocks.MOVING_PISTON && block != Blocks.SPAWNER;
}                                                         ^ here :)

This is probably in consideration of the fact that enchanting tables and ender chests both feature obsidian in their crafting recipes!

@ipg0
Copy link
Author

ipg0 commented Mar 3, 2024

This seems to be intentional, as there's a direct reference to enchanting tables being ignored in PistonBaseBlock_movableBEMixin#isPushableBlockEntity(Block):

private static boolean isPushableBlockEntity(Block block) {
    return block != Blocks.ENDER_CHEST && block != Blocks.ENCHANTING_TABLE && block != Blocks.END_GATEWAY && block != Blocks.END_PORTAL && block != Blocks.MOVING_PISTON && block != Blocks.SPAWNER;
}                                                         ^ here :)

This is probably in consideration of the fact that enchanting tables and ender chests both feature obsidian in their crafting recipes!

I was just playing a modpack which adds another kind of enchanting table, and I had built a massive redstone contraption to switch between a modded ench table and a regular one within a single bookshelf array, only to discover that I can't move the enchanting table with a piston.

I already forked this mod and removed the mentioned check, anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants