Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings reset to default #177

Open
3 of 6 tasks
kenf1 opened this issue Oct 27, 2022 · 6 comments
Open
3 of 6 tasks

Settings reset to default #177

kenf1 opened this issue Oct 27, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@kenf1
Copy link

kenf1 commented Oct 27, 2022

Problem description

Deleting a Anki user profile would reset all Review Heatmap settings to default.

Checklist

Please replace the space inside the brackets with an x if the following items apply:

  • I've restarted Anki to see if it helps
  • I've verified that I use the latest version of the add-on by redownloading it from AnkiWeb
  • I've verified that I use the latest version of Anki by checking at https://apps.ankiweb.net#download
  • I've tried to disable other add-ons to see if there are any interactions present
  • My issue disappears when I hold shift while starting Anki.
  • I've checked if anyone else reported this problem before by looking through the issue reports. I also checked to see if there is a section about known issues in the add-on description, documentation, or README.

Information about your Anki set-up

    Anki 2.1.54 (b6a7760c) Python 3.9.7 Qt 6.3.1 PyQt 6.3.1
    macOS
@kenf1 kenf1 added the bug Something isn't working label Oct 27, 2022
@Ben-Judah
Copy link

I've had the same problem

@voytxt
Copy link

voytxt commented Jan 18, 2023

I have the same problem on Windows with Qt5

    Anki 2.1.56 (07fd88dd) Python 3.9.15 Qt 5.15.2 PyQt 5.15.5
    Platform: Windows-10-10.0.22621
    Flags: frz=True ao=True sv=2
    Add-ons, last update check: 2023-01-18 17:21:25
    
    ===Add-ons (active)===
    (add-on provided name [Add-on folder, installed at, version, is config changed])
    Button Colours Good Again ['2494384865', 2022-09-27T12:18, 'None', '']
    Quizlet to Anki 21 Importer with audio support ['1362209126', 2022-10-30T19:46, 'None', '']
    Review Heatmap ['1771074083', 2022-06-30T03:43, 'None', '']
    Show total time spent in main screen ['1238121460', 2020-07-19T10:36, 'None', '']
    
    ===IDs of active AnkiWeb add-ons===
    1238121460 1362209126 1771074083 2494384865

@glutanimate
Copy link
Owner

Hi there, thanks for the reports guys. Just to clarify, if you mean that Review Heatmap's settings are lost when you delete a profile, I'm afraid that's by design: Review Heatmap's settings are tied to individual Anki profiles, so if you delete a profile, any customizations you applied there will also be deleted.

I suppose this can be confusing compared to other add-ons which provide settings which are common across all profiles. Review Heatmap operates differently here because the data it displays is also tied to individual profiles. E.g.: If you were to customize settings like its date range, those likely wouldn't make sense in the context of a different profile with a different review history.

But I think this could be interesting to get other perspectives on as well. If I may ask, which settings are you customizing in particular and which ones in particular would you expect to apply across all of your profiles?

@glutanimate glutanimate added more info needed More information needed to address issue and removed bug Something isn't working labels Jan 18, 2023
@kenf1
Copy link
Author

kenf1 commented Jan 18, 2023

Let's say my setup was:

  • Profile A
  • Profile B

The only settings I changed were heatmap visibility. I have it hidden on the Main and Deck screens in both profiles.

Deleting B would cause heatmap settings in A to restore to default. In other words, the heatmap that was previously hidden from Main and Deck screens in A are now present again.

Am using Review Heatmap v1.0.1.

@Ben-Judah
Copy link

I've had exactly the same issue, with the only difference being I had the heatmap colour changed in Profile A . When I deleted Profile B, Profile A's heatmap colour reverted back to lime.

However, I haven't done any changes whatsoever to Profile B's heatmap, I only created the profile and then deleted it some days after. When I opened Profile A right after that, the heatmap's settings were reverted to default

I'm also using Review Heatmap v1.0.1.

@glutanimate
Copy link
Owner

@kenf1 @Ben-Judah thanks for the clarification! That's definitely unintended behavior and likely a bug with profile handling. Will look into it.

@glutanimate glutanimate added bug Something isn't working and removed more info needed More information needed to address issue labels Jan 18, 2023
@glutanimate glutanimate self-assigned this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants