Possible no unlock.

[Bbulatov]

Good day!
During the statistical analysis, a situation was found where the lock remained open. Testing was carried out on Linux Debian 11. A LOCK(&cache->gc_lock) is created in the file src/gidcache.c:69. But if you get to line 96, having satisfied all the conditions, it turns out that UNLOCK(&cache->gc_lock) will not be called in any way.
Please clarify whether this is critical and whether changes will be made to the code?

[mohit84]

Good day! During the statistical analysis, a situation was found where the lock remained open. Testing was carried out on Linux Debian 11. A LOCK(&cache->gc_lock) is created in the file src/gidcache.c:69. But if you get to line 96, having satisfied all the conditions, it turns out that UNLOCK(&cache->gc_lock) will not be called in any way. Please clarify whether this is critical and whether changes will be made to the code?

In that case UNLOCK Is call by parent function on the basis of code return by the function gid_cache_lookup.