Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inode->in_lru_list is not really used #4336

Open
mykaul opened this issue Apr 18, 2024 · 0 comments
Open

inode->in_lru_list is not really used #4336

mykaul opened this issue Apr 18, 2024 · 0 comments

Comments

@mykaul
Copy link
Contributor

mykaul commented Apr 18, 2024

ykaul@ykaul:~/github/glusterfs$ grep -Frisn in_lru_list
libglusterfs/src/glusterfs/inode.h:118:    bool in_lru_list;         /* Set if inode is in table lru list */
libglusterfs/src/inode.c:414:    GF_ASSERT(!inode->in_lru_list);
libglusterfs/src/inode.c:417:    inode->in_lru_list = _gf_true;
libglusterfs/src/inode.c:557:            GF_ASSERT(inode->in_lru_list);
libglusterfs/src/inode.c:559:            inode->in_lru_list = _gf_false;
libglusterfs/src/inode.c:693:            GF_ASSERT(!inode->in_lru_list);
libglusterfs/src/inode.c:694:            inode->in_lru_list = _gf_true;
libglusterfs/src/inode.c:1585:            GF_ASSERT(entry->in_lru_list);
libglusterfs/src/inode.c:1603:            entry->in_lru_list = _gf_false;
libglusterfs/src/inode.c:1654:    root->in_lru_list = _gf_true;
libglusterfs/src/inode.c:1867:            GF_ASSERT(trav->in_lru_list);
libglusterfs/src/inode.c:1870:            trav->in_lru_list = _gf_false;

So it's not really used anywhere but in assertions. We can #ifdef this to DEBUG only perhaps.

CC @mohit84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant