Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region roundtrip: Recreate same region from Glue Subset #30

Open
pllim opened this issue May 26, 2021 · 4 comments
Open

Region roundtrip: Recreate same region from Glue Subset #30

pllim opened this issue May 26, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@pllim
Copy link
Contributor

pllim commented May 26, 2021

Is your feature request related to a problem? Please describe it:

I can create a Glue Subset from regions or, somewhat surprisingly, also photutils aperture (in a limited way) using the same API. However, I cannot go the other way. Once region is converted to mask and then MaskSubsetState, the original info is lost.

Describe the solution you'd like:

Someway to preserve the info of how the subset was originally created, so we can recreate it. Though this is really hard to do, if we also let user modify the region interactively after creation, which at least currently does not seem possible.

Describe alternatives you've considered:

Tell the POs to accept the fact that this request is not possible and de-scope spacetelescope/jdaviz#622 / spacetelescope/jdaviz#630 .

Additional context:

To satisfy Imviz non-MVP requirements under contract with STScI.

@pllim
Copy link
Contributor Author

pllim commented May 26, 2021

Or maybe I completely misunderstood this requirement: spacetelescope/jdaviz#530 (comment)

  1. Load and display image 1
  2. Load and display image 2
  3. Match WCS of image 2 to image 1
  4. Plot contours on image 2
  5. Manually adjust contour levels on image 2
  6. Overplot contours from image 2 on image 1 (using existing mechanism)

@astrofrog
Copy link
Member

Over plotting contours can be done currently without the need to use subsets. I'll try and post an example.

@pllim
Copy link
Contributor Author

pllim commented May 26, 2021

Over plotting contours

Whoops... #30 (comment) was mean for glue-viz/glue-jupyter#231

@pllim
Copy link
Contributor Author

pllim commented May 27, 2021

Back to this issue, @eteq says it is not MVP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants