[Macos] After remote inventory, computer comments are replaces by the arch of the cpu

[laszlokertesz]

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Version

10.0.12

Bug description

After upgrading to Glpi 10.0.12 (and glpi inventory plugin to 1.3.4) , most of the macs we have had their comments overwritten by the arch of the cpu and a numbr (i assume some id somewhere) lke

x86_64/2165059

The logs show something like this:

ID 	                        Date 	                        User 	        Field 	        Update
1172050331 	2024-02-26 12:20 	inventory 	Comments 	Update of the field

Most of the macs had previous comments there.
Why is this happening, what is the reason behind this?

Relevant log output

No response

Page URL

No response

Steps To reproduce

We just upgraded the server, most macs that reported after that time got this treatment.

Your GLPI setup information

Information about system installation and configuration

GLPI 10.0.12 ( => /var/www/html/glpi)
Installation mode: TARBALL
Current language:en_GB

Server

 

Operating system: Linux inventory.3pillarglobal.com 6.1.0-18-amd64 #​1 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 (2024-02-01) x86_64

PHP 8.2.7 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apcu, bz2, calendar,

ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml, mbstring, mysqli,

mysqlnd, openssl, pcre, pdo_mysql, posix, random, readline, session, shmop, sockets, sodium, ssh2, standard, sysvmsg, sysvsem,

sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib)

Setup: max_execution_time="30" memory_limit="256M" post_max_size="8M" safe_mode="" session.save_handler="files"

upload_max_filesize="2M" disable_functions=""

Software: Apache ()

Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0

Server Software: Debian 12

Server Version: 10.11.6-MariaDB-0+deb12u1

Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION

Parameters: root@localhost/glpi

Host info: Localhost via UNIX socket

PHP version (8.2.7) is supported.

Sessions configuration is OK.

Allocated memory is sufficient.

mysqli extension is installed.

Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter.

curl extension is installed.

gd extension is installed.

intl extension is installed.

zlib extension is installed.

The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.

Database engine version (10.11.6) is supported.

No files from previous GLPI version detected.

The log file has been created successfully.

Write access to /var/www/html/glpi/files/_cache has been validated.

Write access to /var/www/html/glpi/files/_cron has been validated.

Write access to /var/www/html/glpi/files has been validated.

Write access to /var/www/html/glpi/files/_dumps has been validated.

Write access to /var/www/html/glpi/files/_graphs has been validated.

Write access to /var/www/html/glpi/files/_lock has been validated.

Write access to /var/www/html/glpi/files/_pictures has been validated.

Write access to /var/www/html/glpi/files/_plugins has been validated.

Write access to /var/www/html/glpi/files/_rss has been validated.

Write access to /var/www/html/glpi/files/_sessions has been validated.

Write access to /var/www/html/glpi/files/_tmp has been validated.

Write access to /var/www/html/glpi/files/_uploads has been validated.
Web server root directory configuration seems safe.

PHP directive "session.cookie_secure" should be set to "on" when GLPI can be accessed on HTTPS protocol.

PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values.

OS and PHP are relying on 64 bits integers.

exif extension is installed.

ldap extension is installed.

openssl extension is installed.

Following extensions are installed: bz2, Phar, zip.

Zend OPcache extension is installed.

Following extensions are installed: ctype, iconv, mbstring, sodium.

Write access to /var/www/html/glpi/marketplace has been validated.

Timezones seems loaded in database.

GLPI constants

 

GLPI_ROOT: "/var/www/html/glpi"

GLPI_CONFIG_DIR: "/var/www/html/glpi/config"

GLPI_VAR_DIR: "/var/www/html/glpi/files"

GLPI_MARKETPLACE_DIR: "/var/www/html/glpi/marketplace"

GLPI_USE_CSRF_CHECK: "1"

GLPI_CSRF_EXPIRES: "7200"

GLPI_CSRF_MAX_TOKENS: "100"

GLPI_USE_IDOR_CHECK: "1"

GLPI_IDOR_EXPIRES: "7200"

GLPI_ALLOW_IFRAME_IN_RICH_TEXT: false

GLPI_SERVERSIDE_URL_ALLOWLIST: ["/^(https?|feed):\/\/[^@:]+(\/.*)?$/"]

GLPI_TELEMETRY_URI: "https://telemetry.glpi-project.org"

GLPI_INSTALL_MODE: "TARBALL"

GLPI_NETWORK_MAIL: "glpi@teclib.com"

GLPI_NETWORK_SERVICES: "https://services.glpi-network.com"

GLPI_MARKETPLACE_ALLOW_OVERRIDE: true

GLPI_MARKETPLACE_MANUAL_DOWNLOADS: true

GLPI_USER_AGENT_EXTRA_COMMENTS: ""

GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: "1"

GLPI_AJAX_DASHBOARD: "1"

GLPI_CALDAV_IMPORT_STATE: 0

GLPI_DEMO_MODE: "0"

GLPI_CENTRAL_WARNINGS: "1"

GLPI_TEXT_MAXSIZE: "4000"

GLPI_DOC_DIR: "/var/www/html/glpi/files"

GLPI_CACHE_DIR: "/var/www/html/glpi/files/_cache"

GLPI_CRON_DIR: "/var/www/html/glpi/files/_cron"

GLPI_DUMP_DIR: "/var/www/html/glpi/files/_dumps"

GLPI_GRAPH_DIR: "/var/www/html/glpi/files/_graphs"

GLPI_LOCAL_I18N_DIR: "/var/www/html/glpi/files/_locales"

GLPI_LOCK_DIR: "/var/www/html/glpi/files/_lock"

GLPI_LOG_DIR: "/var/www/html/glpi/files/_log"

GLPI_PICTURE_DIR: "/var/www/html/glpi/files/_pictures"

GLPI_PLUGIN_DOC_DIR: "/var/www/html/glpi/files/_plugins"

GLPI_RSS_DIR: "/var/www/html/glpi/files/_rss"

GLPI_SESSION_DIR: "/var/www/html/glpi/files/_sessions"

GLPI_TMP_DIR: "/var/www/html/glpi/files/_tmp"

GLPI_UPLOAD_DIR: "/var/www/html/glpi/files/_uploads"

GLPI_INVENTORY_DIR: "/var/www/html/glpi/files/_inventories"

GLPI_NETWORK_REGISTRATION_API_URL: "https://services.glpi-network.com/api/registration/"

GLPI_MARKETPLACE_PLUGINS_API_URI: "https://services.glpi-network.com/api/marketplace/"

GLPI_I18N_DIR: "/var/www/html/glpi/locales"

GLPI_VERSION: "10.0.12"

GLPI_SCHEMA_VERSION: "10.0.12@b902ef5f5da967c1a9d0826ee8a7dce07d57cf3d"

GLPI_MARKETPLACE_PRERELEASES: false

GLPI_MIN_PHP: "7.4.0"

GLPI_MAX_PHP: "8.4.0"

GLPI_YEAR: "2024"

Libraries

 

htmlawed/htmlawed version 1.2.14 in (/var/www/html/glpi/vendor/htmlawed/htmlawed)

phpmailer/phpmailer version 6.8.0 in (/var/www/html/glpi/vendor/phpmailer/phpmailer/src)

simplepie/simplepie version 1.5.8 in (/var/www/html/glpi/vendor/simplepie/simplepie/library)

tecnickcom/tcpdf version 6.6.2 in (/var/www/html/glpi/vendor/tecnickcom/tcpdf)

michelf/php-markdown in (/var/www/html/glpi/vendor/michelf/php-markdown/Michelf)

true/punycode in (/var/www/html/glpi/vendor/true/punycode/src)

iamcal/lib_autolink in (/var/www/html/glpi/vendor/iamcal/lib_autolink)

sabre/dav in (/var/www/html/glpi/vendor/sabre/dav/lib/DAV)

sabre/http in (/var/www/html/glpi/vendor/sabre/http/lib)

sabre/uri in (/var/www/html/glpi/vendor/sabre/uri/lib)

sabre/vobject in (/var/www/html/glpi/vendor/sabre/vobject/lib)

laminas/laminas-i18n in (/var/www/html/glpi/vendor/laminas/laminas-i18n/src)

laminas/laminas-servicemanager in (/var/www/html/glpi/vendor/laminas/laminas-servicemanager/src)

monolog/monolog in (/var/www/html/glpi/vendor/monolog/monolog/src/Monolog)

sebastian/diff in (/var/www/html/glpi/vendor/sebastian/diff/src)

donatj/phpuseragentparser in (/var/www/html/glpi/vendor/donatj/phpuseragentparser/src/UserAgent)

elvanto/litemoji in (/var/www/html/glpi/vendor/elvanto/litemoji/src)

symfony/console in (/var/www/html/glpi/vendor/symfony/console)

scssphp/scssphp in (/var/www/html/glpi/vendor/scssphp/scssphp/src)

laminas/laminas-mail in (/var/www/html/glpi/vendor/laminas/laminas-mail/src/Protocol)

laminas/laminas-mime in (/var/www/html/glpi/vendor/laminas/laminas-mime/src)

rlanvin/php-rrule in (/var/www/html/glpi/vendor/rlanvin/php-rrule/src)

ramsey/uuid in (/var/www/html/glpi/vendor/ramsey/uuid/src)

psr/log in (/var/www/html/glpi/vendor/psr/log/Psr/Log)

psr/simple-cache in (/var/www/html/glpi/vendor/psr/simple-cache/src)

psr/cache in (/var/www/html/glpi/vendor/psr/cache/src)

league/csv in (/var/www/html/glpi/vendor/league/csv/src)

mexitek/phpcolors in (/var/www/html/glpi/vendor/mexitek/phpcolors/src/Mexitek/PHPColors)

guzzlehttp/guzzle in (/var/www/html/glpi/vendor/guzzlehttp/guzzle/src)

guzzlehttp/psr7 in (/var/www/html/glpi/vendor/guzzlehttp/psr7/src)

glpi-project/inventory_format in (/var/www/html/glpi/vendor/glpi-project/inventory_format/lib/php)

wapmorgan/unified-archive in (/var/www/html/glpi/vendor/wapmorgan/unified-archive/src)

paragonie/sodium_compat in (/var/www/html/glpi/vendor/paragonie/sodium_compat/src)

symfony/cache in (/var/www/html/glpi/vendor/symfony/cache)

html2text/html2text in (/var/www/html/glpi/vendor/html2text/html2text/src)

symfony/css-selector in (/var/www/html/glpi/vendor/symfony/css-selector)

symfony/dom-crawler in (/var/www/html/glpi/vendor/symfony/dom-crawler)

twig/twig in (/var/www/html/glpi/vendor/twig/twig/src)

twig/string-extra in (/var/www/html/glpi/vendor/twig/string-extra)

symfony/polyfill-ctype not found

symfony/polyfill-iconv not found

symfony/polyfill-mbstring not found

symfony/polyfill-php80 not found

symfony/polyfill-php81 not found

symfony/polyfill-php82 in (/var/www/html/glpi/vendor/symfony/polyfill-php82)

league/oauth2-client in (/var/www/html/glpi/vendor/league/oauth2-client/src/Provider)

league/oauth2-google in (/var/www/html/glpi/vendor/league/oauth2-google/src/Provider)

thenetworg/oauth2-azure in (/var/www/html/glpi/vendor/thenetworg/oauth2-azure/src/Provider)

phpCas version 1.6.0 in (/usr/share/php/CAS/source)

LDAP directories

 

Server: 'ldaps://1.1.1.1', Port: '636', BaseDN: 'DC=domain,DC=corp', Connection filter:

'(&(objectClass=user)(objectCategory=person)(!(userAccountControl:1.2.840.113556.1.4.803:=2)))', RootDN: 'CN=Glpi

Auth,OU=AD,OU=ServiceAccounts,OU=AllUsers,DC=3pillar,DC=corp', Use TLS: none

Server: 'localhost', Port: '1636', BaseDN: 'DC=domain,DC=com', Connection filter: none, RootDN: 'OptimalGre', Use TLS:

none

SQL replicas

 

Not active

Notifications

 

Way of sending emails: PHP

Plugins list

 

glpiinventory        Name: GLPI Inventory                 Version: 1.3.4      State: Enabled

Install Method: Manual

phpsaml              Name: PHP SAML                       Version: 1.3.0      State: Enabled

Install Method: Manual

Anything else?

No response

[cconard96]

By default, the description property in the inventory data is written to the comments. As of GLPI 10.0.12, you should be able to lock this field to prevent it from being overwritten by inventory data (this only blocks automatic changes. manually changing this field would still work).

Administration > Inventory, click "Add global lock" button along the top of the page.

[laszlokertesz]

I looked at that, but there doesn't seem to be an entry for "Computer - Comments", everything else seem to be there.

[laszlokertesz]

By default, the description property in the inventory data is written to the comments.

But if there was something in the comments, why does it overwrites it. We had all kinds of information there, physical inventory dates, previous users etc. Yes most of these can be obtained but it needs looking into logs etc but we use it for quick information lookup, it can be put directly in the filter lists.

The information placed in the comments are meaningless for us and probably to most users that expect that field to be preserved. Maybe the comments should be preserved and these information added instead of deleting the previous ones?

[laszlokertesz]

I looked at that, but there doesn't seem to be an entry for "Computer - Comments", everything else seem to be there.

Hmm i did a html inspection and the entry names "Computer - Location comments has the description of "Computer - comment" in the code. I added that field, let's see what happens.

[trasher]

Maybe the comments should be preserved and these information added instead of deleting the previous ones?

In a normal flow, inventory creates a computer, then you edit the comment. When editing manually, comment field is locked, inventory will not change it again.
If comment field is not locked for any reason (for example you create computer manually first and then it's updated from inventory); adding a global lock on comment field is the way to go.

[AldarisPale]

@laszlokertesz - please check #16256 for more background.
The bad news here is that whatever you had on the comment fields before probably still exists somewhere in the database, but it's not being shown in the UI: #16257

[github-actions]

This issue has been closed as we only track bugs here.

You can get community support on forums or you can consider taking a subscription to get professional support.
You can also contact GLPI editor team directly.