From 7b3704cf993ac79e7a43eaece7c577a1817eb025 Mon Sep 17 00:00:00 2001
From: Alexandre Delaunay <delaunay.alexandre@gmail.com>
Date: Thu, 1 Dec 2022 08:59:11 +0100
Subject: [PATCH] Escape external links URLs

---
 src/Link.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Link.php b/src/Link.php
index 3134313fc4d..4f9e84eb60b 100644
--- a/src/Link.php
+++ b/src/Link.php
@@ -665,7 +665,7 @@ public static function getAllLinksFor($item, $params = [])
             foreach ($links as $key => $val) {
                 $name    = (isset($names[$key]) ? $names[$key] : reset($names));
                 $url     = $val;
-                $newlink = "<a href='$url'";
+                $newlink = '<a href="' . htmlspecialchars($url) . '"';
                 if ($params['open_window']) {
                     $newlink .= " target='_blank'";
                 }
@@ -691,9 +691,9 @@ public static function getAllLinksFor($item, $params = [])
                     $file = reset($files);
                 }
                 $url             = $CFG_GLPI["root_doc"] . "/front/link.send.php?lID=" . $params['id'] .
-                                 "&amp;itemtype=" . $item->getType() .
-                                 "&amp;id=" . $item->getID() . "&amp;rank=$key";
-                $newlink         = "<a href='$url' target='_blank'>";
+                                 "&itemtype=" . $item->getType() .
+                                 "&id=" . $item->getID() . "&rank=$key";
+                $newlink         = '<a href="' . htmlspecialchars($url) . '" target="_blank">';
                 $newlink        .= "<i class='fa-lg fa-fw fas fa-link'></i>&nbsp;";
                 $linkname        = sprintf(__('%1$s #%2$s'), $name, $i);
                 $newlink        .= sprintf(__('%1$s: %2$s'), $linkname, $val);