Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When exporting a report the various dates within the report (e.g. calendar entries, time stamps) may differentiate from what the recipient sees. #4019

Open
elbill opened this issue Mar 11, 2024 · 3 comments

Comments

@elbill
Copy link

elbill commented Mar 11, 2024

What version of GlobaLeaks are you using?

4.14.5

What browser(s) are you seeing the problem on?

All

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

The extracted dates for calendar entries contain a random UTC time (9 or 10.00pm).
For other dates it contains the actual dates and hours.
When extracted the date may not correspond to the one stated in the report that is converted to the local one.

Proposed solution

I would suggest calendar entries to contain only dates and not precise time.
Also when a report is exported to be extracted to the browser date/time zone (in addition the UTC could be also stated in brackets).

@evilaliv3
Copy link
Member

evilaliv3 commented Mar 11, 2024

Thank you @elbill for reporting this.

I will fix the templating system to drop the time printing showing only YYYY-DD-MM and siscarding the part HH:mm

Lets see if this will fix the situation fully or if we have some situations in which the user select a day but the print has some discrepancy (showing the day before or the day after)

@elbill
Copy link
Author

elbill commented Mar 11, 2024

It usually reports day before as it is close to midnight. Calendar entry could be hardwired to YYYY-DD-MM.
The complexity would be with timestamps. It is worth trying to implement a local time export.

evilaliv3 added a commit that referenced this issue Mar 11, 2024
@evilaliv3
Copy link
Member

I agree.

At the moment all is handled with timestamp and the patch that i've issud just remove the hour/minute.

As you say the best would be to correct the client to directly hardwire YYYY-DD-MM and remove any processing from the server.
For retrocompatibility the server will just need to recognize that the data is already in this format and avoid to perform any processing and for when the data is an old timestamp we should perform the same processing that we do now.

evilaliv3 added a commit that referenced this issue Mar 11, 2024
evilaliv3 added a commit that referenced this issue Mar 12, 2024
evilaliv3 added a commit that referenced this issue Mar 14, 2024
evilaliv3 added a commit that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants