Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration date change only applied to new reports #4012

Open
joaomarcosdm opened this issue Feb 29, 2024 · 3 comments
Open

Expiration date change only applied to new reports #4012

joaomarcosdm opened this issue Feb 29, 2024 · 3 comments

Comments

@joaomarcosdm
Copy link

joaomarcosdm commented Feb 29, 2024

What version of GlobaLeaks are you using?

4.13.18

What browser(s) are you seeing the problem on?

Chrome

What operating system(s) are you seeing the problem on?

Windows

Describe the issue

It is not clear that a channel new expiration date is only applied to new reports submitted after the new definition.
expiration

Proposed solution

I think that is important to make it clear on the documentation or in the UI that this definitions only applies to new submissions.
Or, as I was expecting, apply the new expiration date to all existing reports.
expiration_tip

@evilaliv3
Copy link
Member

Thank you for this feedback @joaomarcosdm

At the moment the policy apply as default policy for new report and we consider it should work lik this.

It is very difficult in fact to implement a strategy to change the expiration of every report when you change the default policy because existing reports because:

  • what should one do if the new policy is shorter than the new policy? anticipating the deadline of a report could lead to loose data
  • what if the report is in a closed status and subject to a specific policy of that status?

Please feel free to discuss your ideas if you have already evaluated these aspects.

@joaomarcosdm
Copy link
Author

joaomarcosdm commented Mar 1, 2024

That is a very good point.
I respect the current strategy, but I didn't find any information that this was the behavior of the application. My suggestion is to make it clear on documentation or/and on UI that this is only applied to new reports.

Because "Set the value to 0 to disable this feature" to me indicates that this is all in all disabled. My proposal is to add the text "This is only applied to new reports" or to change the current text to "Set the value to 0 to disable this feature in newer reports".

This is a very small thing, but it makes so much clear sense of what will happen next to change. What is your opinion?

@elbill
Copy link

elbill commented Mar 11, 2024

One new aproach is for old reports to be able to enable and set manualy (in a similar way to notifications). Otherwise just crafification would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants