Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify upstream version checks #1005

Open
bbolker opened this issue Mar 17, 2024 · 1 comment
Open

simplify upstream version checks #1005

bbolker opened this issue Mar 17, 2024 · 1 comment

Comments

@bbolker
Copy link
Contributor

bbolker commented Mar 17, 2024

Mikael Jagan has pointed in this thread that checking on built vs. current versions of upstream packages (TMB, Matrix) can be done more easily, without storing the information in an external file (and relying on a customized make rule for the package, by leveraging R's property of storing the environment at build time. A version of this is implemented here for lme4 (it also checks the ABI, rather than the package version, of Matrix). We should back-port this to glmmTMB (and possibly suggest back-porting it to TMB: in particular, TMB could mimic the Matrix ABI-reporting machinery ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants