Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-boost feature #2619

Open
McKristoffer opened this issue Feb 14, 2024 · 4 comments
Open

Re-boost feature #2619

McKristoffer opened this issue Feb 14, 2024 · 4 comments

Comments

@McKristoffer
Copy link

Pitch

A way to reboost an already boosted post with a single click of a button, instead of having to un-boost and then boost again.

Motivation

I reboost my older posts very frequently, and this would be a nice small QOL feature. Currently reboosting requires me to unboost a post, then wait until the boost gets removed on the server side. Frantically clicking on the boost button while the server is still processing the un-boost action results in a lot of 422 errors being thrown for up to 30 seconds (if the server is being particularly slow that day).

@ShadowJonathan
Copy link

Feels a bit XY, IMO reboosting should be as easy as two clicks, but that 422 error exists because the default queue is still processing removing the boost while another boost tries to bump the database row that is left behind in the interm, its a race condition.

Maybe the boost mechanism/thingie should be changed so that reboosting would simply add a worker job to the default queue to retry boosting when the web handler fails? This way, the boost would still be registered, and take place after the unboosting has been handled.

(And this way, apps dont need to add this extra button, and simply pressing twice would do the same on every app as-is)

@MagicLike
Copy link

(And this way, apps dont need to add this extra button, and simply pressing twice would do the same on every app as-is)

I still think it should be possible to just click once on the already boosted button to do the reboost - as it will take at least a few seconds nontheless. Animations and stuttering in the browser might also be a problem.

@McKristoffer McKristoffer changed the title Re-boost button Re-boost feature Feb 14, 2024
@MagicLike
Copy link

Maybe this is a bit over the top, but should glitch-soc be able to hold multiple boosts of one post, limeshowing them in the post/interaction history of a profile and on someones TL or will this conflict with ActivityPub?

@ledlamp
Copy link

ledlamp commented Feb 23, 2024

and it would be nice to have past boosts stay where they are in the timeline.

but that would require adding the ability to remove those boosts in particular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants