Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing post with threaded mode continues to edit the post #2429

Open
JacksonChen666 opened this issue Sep 30, 2023 · 2 comments · May be fixed by #2430
Open

Editing post with threaded mode continues to edit the post #2429

JacksonChen666 opened this issue Sep 30, 2023 · 2 comments · May be fixed by #2430
Labels
bug

Comments

@JacksonChen666
Copy link

Steps to reproduce the problem

  1. Enable threaded mode
  2. Make a post (the first post)
  3. Make another post (the second post)
  4. Edit first post, and save changes
  5. Try to make another post after editing

Expected behaviour

The edit finishes, and continues posting new posts under the thread.

Actual behaviour

The first post being edited is continuously edited (until the error is realized).

Detailed description

See https://micro.jacksonchen666.com/@jacksonchen666/111153385497261170 as an example

Mastodon instance

micro.jacksonchen666.com

Mastodon version

v4.2.0+glitch.jacksonchen666

Browser name and version

LibreWolf 118.0.1-1

Operating system

macOS 14.0

Technical details

Source code (modifications are version and the logged out web UI for sign up links)
@Plastikmensch
Copy link

Thanks for reporting this!
Can confirm this issue.

I'm not sure what the best fix would be.
We could simply exit threaded mode when editing a toot, or keep track of the last toot in threaded mode and continue from there, but would would require additional code changes.

@JacksonChen666
Copy link
Author

We could simply exit threaded mode when editing a toot,

What I would call "unexpected behavior" (or unintuitive)

or keep track of the last toot in threaded mode and continue from there, but would would require additional code changes.

That makes the most sense to me and would be what I expect.

@Plastikmensch Plastikmensch linked a pull request Oct 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix threaded mode continuesly editing same toot Plastikmensch/mastodon
2 participants
@Plastikmensch @JacksonChen666