Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting containerd directly? (Feature request) #498

Open
CoreTechnologyAG opened this issue Dec 8, 2020 · 13 comments
Open

supporting containerd directly? (Feature request) #498

CoreTechnologyAG opened this issue Dec 8, 2020 · 13 comments

Comments

@CoreTechnologyAG
Copy link

Hello

We use logspout in our docker infrastructure.
Now we are planning to switch to kubernetes based on containerd. Kubernetes doesn't support dockerd anymore in the future.

Is there a plan to migrate/enhance logspout to this?
Thanks

@michaelshobbs
Copy link
Member

michaelshobbs commented Dec 8, 2020

Due to lack of development time, this project has pretty much gone into maintenance mode. However, I am certainly open to guiding and reviewing a PR to achieve this goal.

@onpaws
Copy link

onpaws commented Dec 15, 2020

We use logspout and like it in part b/c of its smaller resource footprint compared to other things out there.
Would you be able to please suggest any spiritually similar alternatives?

@merowing1279
Copy link
Contributor

@michaelshobbs are you working on it or can I take this task?

@michaelshobbs
Copy link
Member

@merowing1279 please by all means feel free to take this. let me know if i can offer any insight or assistance

@merowing1279
Copy link
Contributor

ok :) what I'm understanding here is to use instead of docker socket the containerd socket and asking about log the containerd API. Am I right?

@michaelshobbs
Copy link
Member

sounds right to me? we also need to sort out how we will test and (maybe?) potentially fallback to the previous functionality. if we don't want to do that then we at least need to document the bare minimum docker/containerd version we support after this change.

@merowing1279
Copy link
Contributor

I'm thinking to have the both working version. I will try to prepare a good interface for hiding the type of runtime implementation which is using during starting the logspout.

@michaelshobbs
Copy link
Member

sounds good to me

@merowing1279
Copy link
Contributor

@CoreTechnologyAG are you still waiting for this feature?

@CoreTechnologyAG
Copy link
Author

No we don't need this feature anymore. We switched to filebeat from elastic

@karlvr
Copy link

karlvr commented Jun 3, 2023

@merowing1279 did you make any progress on this? We are considering the switch to containerd and currently use a derivative of this container.

@merowing1279
Copy link
Contributor

@karlvr you can go with containerd.

@rhaex
Copy link

rhaex commented Mar 25, 2024

@karlvr you can go with containerd.

Do you mean that the current logspout version works with containerd as well? Or do we need a special version of it? Could you elaborate a bit more? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants