Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find way to improve matrix updates #174

Open
gkjohnson opened this issue Oct 1, 2020 · 1 comment
Open

Find way to improve matrix updates #174

gkjohnson opened this issue Oct 1, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed three.js
Milestone

Comments

@gkjohnson
Copy link
Owner

We know exactly when matrices need to update because the angles get set so possibly we can improve the matrix update performance.

@gkjohnson gkjohnson added enhancement New feature or request three.js labels Oct 1, 2020
@gkjohnson
Copy link
Owner Author

gkjohnson commented Jan 22, 2021

Plan:

  • Add a 'jointNeedsUpdate' or jointNeedsUpdate field to joints indicating they need an update (or just use existing matrixWorldNeedsUpdate flag)
  • Override the URDFRobot updateMatrixWorld function to iterate over all joints and update their local matrix as well as their childrens world matrices
  • Add an optimizeMatrixUpdate field to URDFRobot that defaults to false that enables or disables this behavior

matrixAutoUpdate could also be disabled by default on the non-joint nodes but it wouldn't be as optimal was the above strategy.

@gkjohnson gkjohnson added this to the v0.9.4 milestone Jan 22, 2021
@gkjohnson gkjohnson modified the milestones: v0.9.5, v0.10.0 Apr 16, 2021
@gkjohnson gkjohnson added the help wanted Extra attention is needed label Apr 16, 2021
@gkjohnson gkjohnson modified the milestones: v0.10.0, v0.10.1 Apr 16, 2021
@gkjohnson gkjohnson modified the milestones: v0.10.2, v0.10.3 Sep 3, 2021
@gkjohnson gkjohnson modified the milestones: v0.10.4, v0.10.5 May 18, 2022
@gkjohnson gkjohnson modified the milestones: v0.10.5, v0.10.6, v0.x.x Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed three.js
Projects
None yet
Development

No branches or pull requests

1 participant