New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSL to RGB forces rounding even with rgb(false) #333

Open

KeyboardDanni opened this issue Apr 4, 2024 · 0 comments

KeyboardDanni commented Apr 4, 2024 •

edited

The code in hsl2rgb.js is forcing the RGB components to be rounded to the nearest integer:

chroma.js/src/io/hsl/hsl2rgb.js

Line 31 in cd1b3c0

[r,g,b] = [round(c[0]*255),round(c[1]*255),round(c[2]*255)];

This means that even if you pass false to rgb(), the resulting color gets rounded. The issue does not occur with HSV.

Minimal reproduction:

import chroma from "chroma-js";

let color = chroma.hsv(260, 0.5, 0.5);
let colorRgb = color.rgb(false); // [ 84.99999999999999, 63.75, 127.5 ]

color = chroma.hsl(260, 0.3333333333333333, 0.375);
colorRgb = color.rgb(false); // [ 85, 64, 128 ]

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment