Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brewer scales does not seem accurate #316

Open
yohanboniface opened this issue Jul 1, 2023 · 0 comments
Open

Brewer scales does not seem accurate #316

yohanboniface opened this issue Jul 1, 2023 · 0 comments

Comments

@yohanboniface
Copy link

Hi!

When using this example from the documentation:

>> chroma.scale('OrRd').colors(5);
Array(5) [ "#fff7ec", "#fdd49e", "#fc8d59", "#d7301f", "#7f0000" ]

I would expect it to return the same colors as ColorBrewer would do:

image

But the results differ:

  • chroma-js: #fff7ec, #fdd49e, #fc8d59, #d7301f, #7f0000
  • ColorBrewer: #fef0d9, #fdcc8a, #fc8d59, #e34a33, #b30000

When I look at the chroma-js code handling this, it seems to me that indeed the brewer management is simplified. But I'm not sure at this point if this is a bug or a feature (to keep the code simple). And also I may be missing something.

So if this is considered as a bug, I can try to work on a proposal. If it's a feature, let's close! And if I'm misunderstandin something, sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant