Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code consistency and structure #2

Open
giulianoassaggio opened this issue Jan 17, 2024 · 1 comment
Open

Code consistency and structure #2

giulianoassaggio opened this issue Jan 17, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@giulianoassaggio
Copy link
Owner

casting int to char

use LongNumber::impl::int_to_char and LongNumber::impl::char_to_int instead of explicit casting and calculating everytime

char v = (r >= 10 && r <= 15) ? static_cast<char>('A' + (r - 10)) : static_cast<char>('0' + r);

variable name

refactor from italian names to english ones

documentations

  • be consistent on documentation language and structure, both in public and private sections.
  • Copy-paste doxygen-style documentation for each overloading
@giulianoassaggio giulianoassaggio added good first issue Good for newcomers documentation Improvements or additions to documentation labels Jan 17, 2024
@giulianoassaggio
Copy link
Owner Author

partially solved with commit 2a87e86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant