This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
Ignore refunds if it was only an credit card authorization #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem explained
The idea here is that when you ignore pending transactions, there might be credit card authorizations (where you will get back the money a few days later) which will be ignored if the N26 config flag
skip_pending_transactionsis set totrue. But once you get the money back, those transactions will be processed and they might mess up your account balance.What this PR does
This PR will also ignore the transactions with the type
AV, but only if the N26 config flagskip_pending_transactionsis set totrue.This closes #44.
Todo List
AV