Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal design system #81

Open
5 of 17 tasks
mittalyashu opened this issue May 24, 2019 · 3 comments
Open
5 of 17 tasks

Thermal design system #81

mittalyashu opened this issue May 24, 2019 · 3 comments
Labels
Design discussion Front end help wanted Extra attention is needed ⚙ Improvement New feature or request 🏃🏻‍♀️ Priority medium Remember to work on this
Projects

Comments

@mittalyashu
Copy link
Member

mittalyashu commented May 24, 2019

Use Vue components everywhere to build the application from a small button to a diff preview component.

Split the components into a separate package so it can be used across Thermal ecosystem (Application, Website, and Marketing).

Questions

  • Should we style the components inline or in separate .sass file?
  • How to name component and props?
  • Is it the best way to use mixins for spacing, font and border?
  • How can we leverage sass variables in Vue components?

PRs

References

We are looking for a more modular way to define and use Vue components for the long term, if you have any feedback or suggestion, 🙏🏻 please drop them in the comment section below.

@mittalyashu mittalyashu added ⚙ Improvement New feature or request help wanted Extra attention is needed discussion Front end Design labels May 24, 2019
@mittalyashu mittalyashu added this to To do in Roadmap via automation May 24, 2019
@mittalyashu mittalyashu pinned this issue May 24, 2019
@mittalyashu mittalyashu added this to Low 🏄🏻‍♂️ in Priority Jun 1, 2019
@naclcaleb
Copy link

Hey @mittalyashu, I asked you about Thermal a couple days ago on Hashnode, and decided I'd take a look.

I'm not really sure what needs to be done for this issue, but I'm happy to help where I can.

I don't have a ton of time though, because I'm busy working on my own app.

@mittalyashu
Copy link
Member Author

mittalyashu commented Jul 21, 2019

Hello @naclcaleb,
Glad to see you here and thanks for checking out this project.

This issue is about splitting the Vue component from the Thermal application and move it to a separate package to create a Thermal Design System.

@naclcaleb
Copy link

It looks like next is something called "Toggle slider"?

@mittalyashu
Copy link
Member Author

This is a toggle slider.

image

Currently, we are using a third-party NPM package, but we want to build our own custom Vue component.

@mittalyashu mittalyashu added the 🏃🏻‍♀️ Priority medium Remember to work on this label Jul 24, 2019
@mittalyashu mittalyashu removed this from Low 🏄🏻‍♂️ in Priority Jul 24, 2019
@mittalyashu mittalyashu unpinned this issue Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design discussion Front end help wanted Extra attention is needed ⚙ Improvement New feature or request 🏃🏻‍♀️ Priority medium Remember to work on this
Projects
Roadmap
  
To do
Development

No branches or pull requests

3 participants
@mittalyashu @naclcaleb and others