Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Toggle switch component #3569

Open
mittalyashu opened this issue Oct 6, 2019 · 13 comments
Open

Custom Toggle switch component #3569

mittalyashu opened this issue Oct 6, 2019 · 13 comments

Comments

@mittalyashu
Copy link
Member

mittalyashu commented Oct 6, 2019

Create a custom toggle switch component for Thermal Design System (TDS).


The currently package vue-js-toggle-button is not reactively toggling the switch. For instance:

commitFeature: {
    get: function() {
        return !!+this.settings.commitFeature;
    },
    set: function(value) {
        this.settings.commitFeature = value ? 1 : 0;
    }
}
@mittalyashu mittalyashu added Front end 🚶🏻‍♀️ Priority low Work on it if possible hacktoberfest Contribute and get a chance to win *free t-shirt and stickers. difficulty: easy labels Oct 6, 2019
@mittalyashu mittalyashu added this to To do in Roadmap via automation Oct 6, 2019
@rampreeth
Copy link

Taking a look at this.

@rampreeth
Copy link

I am facing an issue while trying to set it up locally.

@mittalyashu
Copy link
Member Author

May I know what kind of issue are you facing? @rampreeth

@rampreeth
Copy link

yarn
yarn install v1.19.0
warning package.json: License should be a valid SPDX license expression
warning thermal@0.0.4: License should be a valid SPDX license expression
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
[-/4] ⠠ waiting...
[2/4] ⠠ fsevents
[3/4] ⠠ electron
error /Users/rampreeth.ethiraj/open-source-repos/src/thermal/node_modules/electron: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /Users/rampreeth.ethiraj/open-source-repos/src/thermal/node_modules/electron
Output:
Downloading tmp-7905-0-electron-v5.0.6-darwin-x64.zip
Error: connect ETIMEDOUT 13.234.210.38:443
/Users/rampreeth.ethiraj/open-source-repos/src/thermal/node_modules/electron/install.js:49
  throw err
  ^

Error: connect ETIMEDOUT 13.234.210.38:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1126:14) {
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '13.234.210.38',



warning Error running install script for optional dependency: "/Users/rampreeth.ethiraj/open-source-repos/src/thermal/node_modules/fsevents: Command failed.
Exit code: 1
Command: node install
Arguments:
Directory: /Users/rampreeth.ethiraj/open-source-repos/src/thermal/node_modules/fsevents
Output:

Looks like it is failing when it is trying to install electron.

@mittalyashu mittalyashu added 🏃🏻‍♀️ Priority medium Remember to work on this and removed 🚶🏻‍♀️ Priority low Work on it if possible labels Oct 7, 2019
@mittalyashu
Copy link
Member Author

@rampreeth Seems like the issue is not related to electron instead it's because of the connection timeout.

Error: connect ETIMEDOUT 13.234.210.38:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1126:14) {
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '13.234.210.38',

@mittalyashu
Copy link
Member Author

Wanted to check on the progress for the component @rampreeth.

@rampreeth
Copy link

Yes so I think the issue is with reactivity in vue. We need to probably use this.$set. I'm yet to try that out.

@mittalyashu
Copy link
Member Author

Are you trying to fix an exiting toggle switch or creating a new one?

@rampreeth
Copy link

Existing one itself.

@mittalyashu
Copy link
Member Author

Existing one itself.

No no, seems like you miss-understood the issue title.

You need to create a custom toggle switch component @rampreeth

@rampreeth
Copy link

As per the issue , the existing toggle component is not working right. I think that is happening because of vue reactivity.

@mittalyashu
Copy link
Member Author

Yes, I am aware of that problem, that's why I have created this issue to create a new custom toggle switch component.

@mittalyashu
Copy link
Member Author

@rampreeth did you make any progress in creating custom toggle switch component?

@mittalyashu mittalyashu removed the hacktoberfest Contribute and get a chance to win *free t-shirt and stickers. label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
To do
Development

No branches or pull requests

2 participants