Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Disable email notifications from settings #163

Open
1 task done
nevo-david opened this issue Mar 19, 2024 · 9 comments · May be fixed by #176
Open
1 task done

🚀 Feature: Disable email notifications from settings #163

nevo-david opened this issue Mar 19, 2024 · 9 comments · May be fixed by #176
Assignees
Labels
good first issue Good for newcomers

Comments

@nevo-david
Copy link
Contributor

🔖 Feature description

Some users might want to opt out of getting emails, we need to allow them.

🎤 Why is this feature needed ?

Some people might not want to get transactional emails

✌️ How do you aim to achieve this?

  • Create a new field in the table User called emailNotifications with a default of true!
  • If it's false, in every function in NotificationService we need to opt them out.
  • Add their feature inside of Settings in the system
  • Add the crud for it inside of settings.controller.ts

🔄️ Additional Information

Make sure it's in the User level and not in the Organization level.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@nevo-david nevo-david added the good first issue Good for newcomers label Mar 19, 2024
@ishanarora04
Copy link

@nevo-david can you assign me this issue ?

@nevo-david
Copy link
Contributor Author

Hi @ishanarora04, can you let me know once you have successfully deployed your project on your computer? :)

@ishanarora04
Copy link

@nevo-david got it running on my local.

@nevo-david
Copy link
Contributor Author

Great, assigning this issue to you!

@ishanarora04
Copy link

@nevo-david also I saw your Upwork post for a job. Can you hire me ?

@nevo-david
Copy link
Contributor Author

Well if you manage to solve this issue, I don't see why not :)

@ishanarora04
Copy link

@nevo-david we are looking at Backend Changes only according to above ticket. right ? Also I am assuming we are just stopping the emails, rest all functionality like getting notifications in the notification box remains ?

@ishanarora04
Copy link

@nevo-david any update here ?

@nevo-david
Copy link
Contributor Author

Nope, it's both; why only the backend? @ishanarora04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants