Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: Add a loading in the media uploader #139

Open
1 task done
nevo-david opened this issue Mar 18, 2024 · 18 comments 路 May be fixed by #170
Open
1 task done

馃悰 Bug Report: Add a loading in the media uploader #139

nevo-david opened this issue Mar 18, 2024 · 18 comments 路 May be fixed by #170
Labels
good first issue Good for newcomers

Comments

@nevo-david
Copy link
Contributor

馃摐 Description

In the media uploader we need to add a loader before it shows the media, at the moment it just says there is not media until we see something.

馃憻 Reproduction steps

馃憤 Expected behavior

馃憥 Actual Behavior with Screenshots

馃捇 Operating system

MacOS

馃 Node Version

20

馃搩 Provide any additional context for the Bug.

No response

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@nevo-david nevo-david added the good first issue Good for newcomers label Mar 18, 2024
@bottlewook
Copy link

Can i work on this issue? kindly assign it to me!
What should I use as a loading image?

@nevo-david
Copy link
Contributor Author

Of course, Thank you!

I have created a component called "LoadingComponent" in apps/frontend/src/components/layout/loading.tsx
You can just show this component.

I am assigning this to you.

@bottlewook
Copy link

Can you tell me on which pages this image upload feature is used?

@nevo-david
Copy link
Contributor Author

Look for MediaComponent

@bottlewook
Copy link

Sorry, I don't know the API key so I can't test it locally

@nevo-david
Copy link
Contributor Author

@bottlewook which API keys are missing for you?

@bottlewook
Copy link

bottlewook commented Mar 19, 2024

釀夅叧釀忈叧釀呩叺釂剦釁a喓 2024-03-19 釀嬦叐釀掅叜 1 15 45

I actually can't log in, so I don't know how the image upload works.
so I can't work on it. Sorry.
釀夅叧釀忈叧釀呩叺釂剦釁a喓 2024-03-19 釀嬦叐釀掅叜 1 33 22

釀夅叧釀忈叧釀呩叺釂剦釁a喓 2024-03-19 釀嬦叐釀掅叜 1 33 52

@nevo-david
Copy link
Contributor Author

@bottlewook I pushed a new version that doesn't require a key, can you take the new version and try again?

@bottlewook
Copy link

@nevo-david Yes, I'll try again!

@bottlewook
Copy link

Sorry, I'm getting this error again

釀夅叧釀忈叧釀呩叺釂剦釁a喓 2024-03-19 釀嬦叐釀掅叜 1 52 20

@nevo-david
Copy link
Contributor Author

it's a different error, I will upload today the quick start guide on how to install the project.
You didn't connect your Postgres

@bottlewook
Copy link

Thanks for the guide, I'll work on it as soon as you post it.

@nevo-david
Copy link
Contributor Author

@bottlewook check this out :)
https://docs.gitroom.com/quickstart

@bottlewook
Copy link

@nevo-david I read the documentation you sent me, installed postsql in docker, and tried it, but I get this error
釀夅叧釀忈叧釀呩叺釂剦釁a喓 2024-03-19 釀嬦叐釀掅叜 6 55 32

@nevo-david
Copy link
Contributor Author

After you install Postgres and Redis you have to add them into the .env
like

REDIS_URL="redis://localhost:6379"
DATABASE_URL="postgres://root:<your_password>@localhost:5432/gitroom"

is the one you specified when you installed postgres

@bottlewook
Copy link

@nevo-david check PR plz~

@rahil1202
Copy link

rahil1202 commented May 1, 2024

Gone through previous chat, I totally understand what you are requesting
I'll submit the PR

@shreykul
Copy link

shreykul commented May 4, 2024

Hi @nevo-david, I wanted to explore this issue, but I don't see any channels added...?
Can you tell me what I did wrong in setting up the project?

@wangc9 wangc9 linked a pull request May 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants