Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool-vnc (workspace-full-vnc) needs some patches for adapting with new Ubuntu Jammy #1067

Open
axonasif opened this issue Mar 24, 2023 · 0 comments · May be fixed by #1104
Open

tool-vnc (workspace-full-vnc) needs some patches for adapting with new Ubuntu Jammy #1067

axonasif opened this issue Mar 24, 2023 · 0 comments · May be fixed by #1104
Labels
bug Something isn't working team: workspace

Comments

@axonasif
Copy link
Member

axonasif commented Mar 24, 2023

Bug description

  • /tmp/.X0-lock is no longer being created by the updated display server, but the vnc startup script checks for it's existence to determine if the vnc server is already running1. Because of that, the startup script is executed for every new terminal even if vnc is running. Also a race condition may exist now when you have many supervisor tasks since the IDE process doesn't start with the login shell anymore for performance reasons (not related with Jammy).
  • Upon opening Google chrome, it prompts for a keyring password, not sure if this was the case in Focal, some packages probably changed their config.

Steps to reproduce

Expected behavior

gp-vncsession script should only run in one place at a time (ideally the first terminal created). And there should be no race conditions.

Additionally, chrome should not prompt for a keyring password since it's not helpful in the context of Gitpod and can break some automations from .gitpod.yml tasks.

Example repository

No response

Anything else?

gitpod/workspace-full-vnc is not broken on Jammy, it works, but it might have some race condition and unexpected restarts of the vnc server.

Front logo Front conversations

https://gitpod.slack.com/archives/C02P236JZPC/p1687448446860189

Footnotes

  1. https://github.com/gitpod-io/workspace-images/blob/5530267b5da00c49be537ddfd8740b99daeaf217/chunks/tool-vnc/gp-vncsession#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team: workspace
Projects
None yet
1 participant