Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Docker image not rebuild correctly after merging #19352

Open
2 tasks
JuJup opened this issue Jan 25, 2024 · 0 comments
Open
2 tasks

Custom Docker image not rebuild correctly after merging #19352

JuJup opened this issue Jan 25, 2024 · 0 comments
Labels
team: team-engine type: bug Something isn't working

Comments

@JuJup
Copy link

JuJup commented Jan 25, 2024

Bug description

We have a very strange behavior with our Gitpod Setup using a custom Dockerfile.
We have a main branch A and a feature branch B. In B we're testing some new things so the Dockerfile differs slightly but is mainly equal to A. From time to time, we merge the main branch A into the feature branch B to keep it up to date.
In this case, the Docker Image is rebuild for B, but with the Dockerfile from A.
Sounds confusing? Yes it is :lau

I described the steps using a minimal example to show the problem:

Steps to reproduce

  1. Create a project with these two files (main):
# .gitpod.Dockerfile
FROM gitpod/workspace-base:latest

RUN touch main-branch.info
# .gitpod.yml

image:
  file: .gitpod.Dockerfile
  1. Start a Gitpod workspace for main
    -> ls ~ should show only main-branch.info

  2. Create a Feature Branch (test-branch) and change the Dockerfile to:

# .gitpod.Dockerfile
FROM gitpod/workspace-base:latest

RUN touch main-branch.info

RUN touch test-branch.info
  1. Start a Gitpod workspace for test-branch
    -> ls ~ should show main-branch.info and test-branch.info
    -> So far everything is fine

  2. Make a change to Dockerfile in main:

# .gitpod.Dockerfile
FROM gitpod/workspace-base:latest

RUN touch main-branch-refactored.info
  1. Start a Gitpod workspace for main
    -> ls ~ should show only main-branch-refactored.info

  2. Merge main into test-branch:

  3. Start a Gitpod workspace for test-branch
    -> ls ~ shows main-branch-refactored.info but not test-branch.info ⚠️

That's already confusing, as the code now doesn't represent the state anymore. So I tried rebuilding the image explicitely:

  1. Open https://gitpod.io/#imagebuild/https://gitlab.com/<group>/<project>/-/tree/test-branch
    -> Image is rebuild (you can see the logs, but you can see it's the wrong Dockerfile from main)
    -> ls ~ shows main-branch-refactored.info but not test-branch.info ⚠️

The only thing that helps now is changing some line in the Dockerfile in test-branch. But this can't be the solution honestly.

Workspace affected

No response

Expected behavior

  • When the Dockerfile changes (no matter if directly in the branch or through a merge from main branch), the Image should be rebuild correctly from the branch's Dockerfile
  • When I use https://gitpod.io/#imagebuild/, I expect the rebuild to be base on the branch's Dockerfile

Example repository

No response

Anything else?

No response

@JuJup JuJup added the type: bug Something isn't working label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: team-engine type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant