Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Shift+G shown as keyboard shortcut, but doesn't work when GitLens is installed #423

Closed
AArnott opened this issue Jun 18, 2018 · 7 comments
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature wontfix Will not be worked on

Comments

@AArnott
Copy link

AArnott commented Jun 18, 2018

From @AArnott on June 13, 2018 14:1

Issue Type: Bug

When I hover over the button that activates the Git panel, it tells me that Ctrl+Shift+G will activate it. But it does not. Rather, that keystroke changes the status bar to indicate it is waiting for the second chord in a multi-keystroke sequence. Pressing Ctrl+Shift+G again is rejected as a non-existent chord.

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:35:40.560Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.93GB (1.80GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe .\assert.xunit|
Screen Reader no
VM 0%
Extensions (19)
Extension Author (truncated) Version
vscode-markdownlint Dav 0.18.0
vscode-eslint dba 1.4.12
githistory don 0.4.1
xml Dot 2.3.0
gitlens eam 8.3.5
EditorConfig Edi 0.12.4
tslint eg2 1.0.30
git-project-manager fel 1.6.1
docker-linter hen 0.5.0
docomment k-- 0.1.0
azure-account ms- 0.4.0
cpptools ms- 0.17.4
csharp ms- 1.15.2
liveshare-logviewer ms- 0.2.1
PowerShell ms- 1.7.0
team ms- 1.136.0
vscode-docker Pet 0.0.27
java red 0.26.0
vsc-docker Zim 0.34.0

(1 theme extensions excluded)

Copied from original issue: microsoft/vscode#51767

@AArnott
Copy link
Author

AArnott commented Jun 18, 2018

From @RMacfarlane on June 13, 2018 17:15

Can you run Preferences: Open Keyboard Shortcuts and search Show SCM to see what the binding for that is? Can you also check to see if you have any installed keymaps with Preferences: Keymaps?

@AArnott
Copy link
Author

AArnott commented Jun 18, 2018

I don't have any installed keymaps.

Here is what I see on Open Keyboard Shortcuts:
image

I have not modified these directly in any way.

Thanks.

@AArnott
Copy link
Author

AArnott commented Jun 18, 2018

From @RMacfarlane on June 13, 2018 22:7

Ah, ok. It looks like the GitLens extension is using Ctrl+Shift+G as the prefix for its keybindings, which is why VSCode waits for more input. You can add "gitlens.keymap": "none" to your settings or use the Ctrl+Shift+G+G shortcut à la GitLens. Regardless, we should display the correct keybinding to open the view when you hover

@AArnott
Copy link
Author

AArnott commented Jun 18, 2018

From @vscodebot[bot] on June 18, 2018 12:41

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@AArnott AArnott changed the title Incorrect keybinding shown on hover for opening viewlet when there are multiple keybindings that begin with the same chord Ctrl+Shift+G shown as keyboard shortcut, but doesn't work when GitLens is installed Jun 18, 2018
@eamodio
Copy link
Member

eamodio commented Jun 18, 2018

Unfortunately I've gone through too many changes with key bindings conflicting with everything, so ultimately I added the quick escape hatch via gitlens.keymap which can be set to chorded (the default set), alternate (alt-based set), and none (no keybindings).

I would really love vscode to fix microsoft/vscode#40389 to reduce confusion, but at least for now I'm not planning on changing this.

Sorry.

@eamodio eamodio closed this as completed Jun 18, 2018
@eamodio eamodio added wontfix Will not be worked on blocked: vscode Caused by or dependent on a VS Code issue or feature labels Jun 18, 2018
@gnppro
Copy link

gnppro commented Jan 17, 2020

Git Source Control (SCM) => "ctrl+shift+g g"
Git Lends => "ctrl+shift+g shift+b"

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature wontfix Will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants