Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap3 not compatible with current tagfilter-plugin #600

Open
virk opened this issue Oct 24, 2023 · 7 comments
Open

bootstrap3 not compatible with current tagfilter-plugin #600

virk opened this issue Oct 24, 2023 · 7 comments
Labels

Comments

@virk
Copy link

virk commented Oct 24, 2023

Description

Updated tagfilter does not filter the tags in bootstrap, but displays all tagged pages.

Steps to reproduce

Install and configure tagfilter
Expected behavior: I expect that only tagged entries are shown which I wanted to be shown by choosing the desired tag with tagfilter.

Actual behavior: All entries of all tagged pages are displayed. With dokuwiki-template everything works as intended. You might also have a look at the thread at issues at tagfilter: [https://github.com/lisps/tagfilter/issues/29] There is a work-around to replace code in tagfilter/script.js at line 116 to the old code.

Versions

  • [Bootstrap3 Template] Current version
  • [DokuWiki] Jack Jackrum
  • [Plugins] Many
  • [PHP] 7.4 and 8.2
  • [Browser] Apple Safari and Apple Chrome

Screenshots or Logs

[Paste your logs or attach the screenshot]

Sample page or snippet

[Paste your sample DokuWiki page or snippet using MarkDown code syntax]

BTW: I saw that I judged it to be a bug; I do not know whether this is a bug (or whether I am just stupid, Do not ask my wife) but do not know how to undo this classification ;-)

@virk virk added the bug label Oct 24, 2023
@fjf2002
Copy link

fjf2002 commented Oct 31, 2023

Concerning the tagfilter plugin: I thought it should work for any template.

Sorry, couldn't reproduce your issue with "Jack Jackrum" and Chrome Browser.

  • Do you have the newest version of the tagfilter plugin installed?
  • What exact configuration do you have for
    • the bootstrap template
    • the pagelist template
  • What exact command are you using for your tagfilter?

@virk
Copy link
Author

virk commented Oct 31, 2023

  1. Yes, I installed the newest version of tagfilter. BTW: It only appeared after an update of tagfilter.
  2. Template version v2022-07-27 (stable/20220727)
    DokuWiki version: Release 2023-04-04a "Jack Jackrum"

{{tagfilter>?Projekt=project:.*|Art=art:.*|Detail=detail:.*|Jahr=year:.*&nouser&nodate&noneonclear&count&multi}}

When I double the "{{tagfilter..."-line to

{{tagfilter>?Projekt=project:.*|Art=art:.*|Detail=detail:.*|Jahr=year:.*&nouser&nodate&noneonclear&count&multi}}
{{tagfilter>?Projekt=project:.*|Art=art:.*|Detail=detail:.*|Jahr=year:.*&nouser&nodate&noneonclear&count&multi}}

I get "everything" twice, but then it displays the tagged pages as intended.
Here the behaviour is the same, whether Safari 17.1 or Chrome.
php-version is 8.2.12, but the "problem" also appears with php@7.4.x

ONE FURTHER REMARK: If I change in configuration "plugin»pagelist»style" in pagelist to simple list, it seems to work as intended, too.

@fjf2002
Copy link

fjf2002 commented Oct 31, 2023

Thank You for your detailed explanation.
You say pagelist-style "simplelist" works; which ones don't work? All others?

@fjf2002
Copy link

fjf2002 commented Oct 31, 2023

Quick solution: edit tagfilter's lib/plugins/tagfilter/script.js Line 118, remove the class from the div so that div.table becomes just div .

I have made a Pull Request to the tagfilter plugin: lisps/tagfilter#33

@virk
Copy link
Author

virk commented Oct 31, 2023

1.) Yes, all others do not work
2.) Okay, thanks for the fix. A workaround/fix somebody also figured out in the parallel (tagfilter)-thread. In our active company's wiki I will not update currently. I always test everything at at non-active-copy of the wiki and during the tagfilter-update this happened. I will wait, because I currently do not know, what the cause of the malfunction is. Is it the
bootstrap3-template->because dokuwiki-template works
pagelist plugin-> because simple list works
tagfilter plugin-> perhaps it is related to this

One question of mine: Could you now experience/reproduce the behaviour/mistake by yourself?

Later: I applied your "quick solution" to a copied wiki and it seems to work.

Thanks again!

@fjf2002
Copy link

fjf2002 commented Oct 31, 2023

I can tell you the cause.

I myself had made a PR to the tagfilter plugin that introduced support for including whole pages with the include plugin.
I introduced the bug (and another).

  • You know, at first it has to work with every pagelist style setting.
  • And at second, today I had to learn from you that the bootstrap3 template manipulates the dokuwiki <div class="table"> div class name, which I did not expect at all.

@fjf2002
Copy link

fjf2002 commented Oct 31, 2023

I think the ticket can be closed when my tagfilter PR gets accepted there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants